The method creates a link, an edge between two nodes, and calculates the Euclidean distance.
I'm testing that after linking, the link does indeed exist, and that the distance is correct.
I've used a variety of test cases, to check that it works for both horizontal and vertical links (just incase there's a divide by zero error), and as well as forward and backwards to check that it doesn't return a negative value.
import unittest
from graph import SpatialGraph
class TestSpatialGraph(unittest.TestCase):
#cleardown any existing graph.
def setUp(self):
print "TestSpatialGraph Setup"
g = None
def testCreateLink_00_01(self):
g = SpatialGraph(2,2)
g.addNode(0, 0,0)
g.addNode(1,0,1)
g.createLink(0,1)
self.assertTrue(g.link_matrix[0][1])
self.assertTrue(g.link_matrix[1][0])
self.assertEquals(g.distMatrix[0][1],1000)
self.assertEquals(g.distMatrix[1][0],1000)
def testCreateLink_00_11(self):
g = SpatialGraph(2,2)
g.addNode(0, 0,0)
g.addNode(1,1,1)
g.createLink(0,1)
self.assertTrue(g.link_matrix[0][1])
self.assertTrue(g.link_matrix[1][0])
self.assertEquals(g.distMatrix[0][1],1414)
self.assertEquals(g.distMatrix[1][0],1414)
def testCreateLink_00_10(self):
g = SpatialGraph(2,2)
g.addNode(0, 0,0)
g.addNode(1,1,0)
g.createLink(0,1)
self.assertTrue(g.link_matrix[0][1])
self.assertTrue(g.link_matrix[1][0])
self.assertEquals(g.distMatrix[0][1],1000)
self.assertEquals(g.distMatrix[1][0],1000)
def testCreateLink_10_00(self):
g = SpatialGraph(2,2)
g.addNode(0, 1,0)
g.addNode(1,0,0)
g.createLink(0,1)
self.assertTrue(g.link_matrix[0][1])
self.assertTrue(g.link_matrix[1][0])
self.assertEquals(g.distMatrix[0][1],1000)
self.assertEquals(g.distMatrix[1][0],1000)
def testCreateLink_11_00(self):
g = SpatialGraph(2,2)
g.addNode(0, 1,1)
g.addNode(1,0,0)
g.createLink(0,1)
self.assertTrue(g.link_matrix[0][1])
self.assertTrue(g.link_matrix[1][0])
self.assertEquals(g.distMatrix[0][1],1414)
self.assertEquals(g.distMatrix[1][0],1414)
def testCreateLink_01_00(self):
g = SpatialGraph(2,2)
g.addNode(0, 0,1)
g.addNode(1,0,0)
g.createLink(0,1)
self.assertTrue(g.link_matrix[0][1])
self.assertTrue(g.link_matrix[1][0])
self.assertEquals(g.distMatrix[0][1],1000)
self.assertEquals(g.distMatrix[1][0],1000)
Here's some questions I have:
Obviously the code is repetitive. But I'm told that for unit tests, you shouldn't genericise, and instead should repeat yourself. (But what if I change one of the methods use? Won't going through each of the tests and refactoring be a pain?).
It assumes that
addNode
is working correctly. But is this how unit tests work? I then also have tests to check thataddNode
is working correctly, and then assume after that that everywhere else it is indeed working correctly.I'm not testing for more distances. This was perhaps laziness on my part. I check just the one diagonal, and it's indeed calculating that distance correctly.
What else am I meant to have in a
setUp
method?Each test is in its own method. Should they perhaps be all just one test?