5
\$\begingroup\$

I have an array like this (make sure you scroll to the right):

[0,0,0,0,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0]

Where it will always be the same length. And there will always be some number of 0's surrounding some number of 1's. I am trying to find a good/efficient/smart way to turn the middle of the array of into 0's when there is a padding of 4 1's on each side. The result would be something like:

[0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0]

Where you now have a padding of 4 1's on either side.

This is how I implemented it:

var a = [0,0,0,0,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0];

var hitOne = false;
var oneCount = 0;
var oneStopPoint = a.lastIndexOf(1) - 3;
for(var n in a){
    if(n == oneStopPoint){
        break;   
    }
    if(a[n] == 1 && !hitOne) {
        hitOne = true
        oneCount++;
    } else if(a[n] == 1 && hitOne) {
        oneCount++;
    }
    if(oneCount > 4){
        a[n] = 0;
    }
}
console.log(a);

http://jsfiddle.net/4gk9L9uv/1/

\$\endgroup\$
2
  • 2
    \$\begingroup\$ "And there will always be some number of 0's surrounding some number of 1's." Not after your transformation. What is the purpose of this array and the transformation? By the way, Do you realise that that array could be represented as [4, 47, 13] or [[0, 4], [1, 47], [0, 13], while the transformed version could be [[0, 4], [1, 4], [0, 39], [1, 4], [0, 13]]. Your array could be regenerated from those at any time. So maybe there are alternative ways to work with this data... \$\endgroup\$
    – itsbruce
    Dec 5, 2014 at 3:45
  • \$\begingroup\$ @itsbruce this array is a row (of many rows) of tiles in a game. Initially there will always be some number of 0's surrounding some number of 1's. \$\endgroup\$
    – Johnston
    Dec 5, 2014 at 4:00

2 Answers 2

5
\$\begingroup\$

Firstly: Don't use for...in on arrays.

Secondly, I suppose you can find the 1-boundaries, and add/subtract 4:

var left = array.indexOf(1) + 4;
var right = array.lastIndexOf(1) - 4;
for(; left <= right ; left++) {
  array[left] = 0;
}

Not particularly clever, but it does the job.

(Note: lastIndexOf is widely supported in modern runtimes, but older ones may not have it)

But also take @itsbruce's advice from the comments, and consider another structure for these data.

\$\endgroup\$
3
  • \$\begingroup\$ indexOf() is O(n). Given that you know that there is only one contiguous subsequence of 1's, there exist more efficient ways to find its boundaries. The algorithm would be similar as the ones used for searching in ordered lists. \$\endgroup\$
    – abl
    Dec 5, 2014 at 22:24
  • \$\begingroup\$ @abl I did consider that (was thinking something like a binary search), but I found no reason to complicate things. \$\endgroup\$
    – Flambino
    Dec 5, 2014 at 22:39
  • \$\begingroup\$ @Flambino I also think that it may be unnecessary, especially since, being a game, it's likely that the length of the array will not be arbitrarily long. But the OP explicitly asked for an efficient solution so I guess it may be worth mentioning this point. \$\endgroup\$
    – abl
    Dec 5, 2014 at 22:56
0
\$\begingroup\$

Here's what I came up with:

function fillOnes(array, padding) {
  for (var i = 0, ones = 0; i < array.length; i++) {
    if (array[i] === 0) {
      for (var j = i - ones + padding;
           j < i - padding;
           array[j] = 0, j++);
      ones = 0;
    } else {
      ones++;
    }
  }
}

I agree with what itsbruce said, however; it would be much better to rework your data structure than do something like this.

\$\endgroup\$

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.