That depends on how confident you are that neither of these cases will be true:
- Another tag like will be introduced that you will want to leave unfiltered
- No nested tags will appear within the tag
An example of the last would be:
It seems your assumptions are safe, but if you want to be certain, go with
self.request.gsub! /\<UserPassword\>.+?\</UserPassword\>/gm, '<UserPassword>[FILTERED]</UserPassword>'
By eliminating the greediness of the regex, you can match the exact tag you mean and reduce the assumptions that will come back and bite you.