This review is very short and very straight-forward. There are two people in the team and the checked-in code looks as follows.
string parameter = GetUnitType(); string target = "PM4000"; if(parameter.CompareTo(target) == 0) CarryOutProcess();
I got stuck here and needed to re-check the usage of CompareTo. I can't for my life understand any advantage of the above in comparison to:
string parameter = GetUnitType(); if(parameter == "PM4000") CarryOutProcess();
I'm pretty sure it's just a case of intentional obfuscation or, at the very least, lack of understanding a copied code.
Is the former inferior to the latter in every possible way?
The author of the first claims that since both work, they're comparably good and the difference is just a matter of personal taste.