Recently I have been learning Python programming, for about a week. I have covered all basic stuff - loops, strings, input masks - and have challenged myself by making a little game. It isn't much, that I know, but I was just wandering whether or not I have done everything correctly.
Any feedback regarding functions and methods used would be greatly appreciated.
import random
cards = ["2","3","4","5","6","7","8","9","10","Jack","Queen","King","Ace"]
suits = ["Spades","Hearts","Clubs","Diamonds"]
x = 1
while x < 20:
for i in range(1,9):
cardVal = cards[random.randint(0,12)]
cardNum = cards.index(cardVal)
suitVal = suits[random.randint(0,3)]
if i == 1:
print("Your starting card is the",cardVal,"of",suitVal)
HoL = str(input("Higher (H), Lower (L) or Same (S): "))
if HoL == "H":
newCval = cards[random.randint(0,12)]
newCnum = cards.index(newCval)
if newCnum < cardNum + 1:
print("Sorry, you fail. Card is",newCval,"of",suitVal)
break
elif newCnum > cardNum:
print("Good job! Card is",newCval,"of",suitVal)
else:
print("Sorry, you fail. Card is",newCval,"of",suitVal)
break
if HoL == "L":
newCval = cards[random.randint(0,12)]
newCnum = cards.index(newCval)
if newCnum > cardNum - 1:
print("Sorry, you fail. Card is",newCval,"of",suitVal)
break
elif newCnum < cardNum:
print("Good job! Card is",newCval,"of",suitVal)
else:
print("Sorry, you fail. Card is",newCval,"of",suitVal)
break
if HoL == "S":
newCval = cards[random.randint(0,12)]
newCnum = cards.index(newCval)
if newCnum != cardNum:
print("Sorry, you fail. Card is",newCval,"of",suitVal)
break
else:
print("Good job! Card is",newCval,"of",suitVal)
print("Congratulations!")
repeat = str(input("Enter 'Yes' to run again: "))
if repeat != "Yes":
break