2
\$\begingroup\$

I'm trying to write the most efficient query I can to pull the relevant data I need for retrieving the latest conversations for a user, ordering groupings of conversations by most recent message in that conversation.

I don't like the idea of using a subselect to match the max timestamp. Is there a better or more efficient way to do this?

SELECT c.id, c.fromUserId, c.toUserId, m.userId, m.message, m.timestamp, pm.filename AS thumbnail, u.username
FROM conversations c, messages m, productmedia pm, users u
WHERE (c.fromUserId = '9' OR c.toUserId = '9')
AND c.id = m.conversationId
AND m.timestamp = (SELECT MAX(m.timestamp) FROM messages m WHERE m.conversationId = c.id)
AND c.productId = pm.productId
AND pm.sortOrder = '0'
AND m.userId = u.id
GROUP BY c.id
ORDER BY m.timestamp DESC
\$\endgroup\$
1
\$\begingroup\$

This SQL of yours has three issues I want to address before looking at the performance...

Formatting:

SELECT c.id,
       c.fromUserId,
       c.toUserId,
       m.userId,
       m.message,
       m.timestamp,
       pm.filename AS thumbnail,
       u.username
FROM conversations c,
     messages m,
     productmedia pm,
     users u
WHERE (c.fromUserId = '9' OR c.toUserId = '9')
  AND c.id = m.conversationId
  AND m.timestamp = (
           SELECT MAX(m.timestamp)
           FROM messages m
           WHERE m.conversationId = c.id)
  AND c.productId = pm.productId
  AND pm.sortOrder = '0'
  AND m.userId = u.id
GROUP BY c.id
ORDER BY m.timestamp DESC

I am not advocating the above as the right way to indent SQL, but, it is consistent, and it allows you to more easily see what is what in the query. What's nice is that you have consistently capitalized the keywords, etc. so that's good.

I am familiar with the above indenting/layout, so, I can now more easily see the next two issues....

Aliases:

You have the table messages twice in your query, once in the sub-select, and again in the main query. Both of these instances of the table have the alias m.... <sarcasm>this is not at all confusing... </sarcasm>

Group By:

Your group by clause is one of those things that will never be resolved to my satisfaction. MySQL has what I consider to be a bug.....(they call it a feature) ..... a massive, oh-my-god, how-could-they-do-that, what-were-they-thinking bug.

What does this mean practically? It means that your query makes no sense to anyone other than a MySQL expert. Your query makes no sense to me.... I can't help. I don't know what the expected behaviour is in your code. Your query does not even contain any aggregated values? Huh!

Next steps:

  • Figure out what you are grouping by (or even if the group-by is needed).
  • pull an explain-plan from the database when it runs the query.
\$\endgroup\$
  • \$\begingroup\$ Thank you very much for the reply. First off, I definitely realized I didn't need that group by - that was more of a remnant from other solutions I was trying. The formatting is something I came up with myself, although I do like how you format - it's definitely easier to glance through. As far as the messages alias goes, would I just refer to messages m as just 'm' in the subquery? \$\endgroup\$ – Braydon Batungbacal Jul 3 '14 at 4:20
  • \$\begingroup\$ About the alias... I would just replace the m in the subselect with a different alias, like subm or something... \$\endgroup\$ – rolfl Jul 3 '14 at 4:24

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.