24
\$\begingroup\$

To detect int overflow/underflow in C, I use this code. What might be a simpler and more portable way of coding this (that is, fewer tests)?

Assume 2's complement and don't use wider integers.

int a,b,sum;
sum = a + b;
// out-of-range only possible when the signs are the same.
if ((a < 0) == (b < 0)) {
  if (a < 0) {
    // Underflow here means the result is excessively negative.
    if (sum > b) UnderflowDetected();
  }
  else {
    if (sum < b) OverflowDetected();  
  }
\$\endgroup\$
  • \$\begingroup\$ I think you're misunderstanding underflow ... or am I? Let's say, as an example, the smallest number a float can represent is 0.001. 1.0 / 10000 would result in a value of 0.0 because the actual value is too small. \$\endgroup\$ – Fiddling Bits Dec 12 '13 at 0:44
  • 1
    \$\begingroup\$ @BitFiddlingCodeMonkey this is on integers - there are various wrap-around cases where the result of an addition does not fit in the same size integer. Sometimes it's called underflow when it's the sum of two negative numbers that doesn't fit. \$\endgroup\$ – Michael Urman Dec 12 '13 at 1:01
  • 2
    \$\begingroup\$ If you just change from using int to using unsigned int, or better still, uint32_t and size_t, you'll be able to do those checks after the operation. For signed ints, overflow and underflow can't be detected after-the-fact because of undefined behaviour. And be warned: undefined behaviour can exhibit itself as anything from the program appearing to work properly right through to malware being installed on your machine and being used to steal your credit card information. \$\endgroup\$ – Matt Dec 12 '13 at 12:10
  • 2
    \$\begingroup\$ @chux: No - I was merely pointing out that the method employed here (i.e. do an add and then see if an overflow occurred) is valid only on unsigned integers. For signed integers it is never valid because overflow of signed integers is inherently undefined in the language. \$\endgroup\$ – Matt Dec 12 '13 at 15:52
  • 2
    \$\begingroup\$ From GCC 5, there are builtin functions to do this. \$\endgroup\$ – o11c Jun 17 '15 at 23:09
40
\$\begingroup\$

It's not possible to avoid undefined behaviour by testing for it after the fact! If the addition overflows then there is already undefined behaviour here:

sum = a + b;

so attempting to test afterwards is too late. You have to test for possible overflow before you do a signed addition. (If you're puzzled by this, read Dietz et al. (2012), "Understanding Integer Overflow in C/C++". Or even you're not puzzled: it's an excellent paper!)

If it were me, I'd do something like this:

#include <limits.h>

int safe_add(int a, int b) {
    if (a > 0 && b > INT_MAX - a) {
        /* handle overflow */
    } else if (a < 0 && b < INT_MIN - a) {
        /* handle underflow */
    }
    return a + b;
}

but I'm not entirely sure what the point of having separate cases for overflow and underflow is.

I also use Clang's -fsanitize=undefined when building for test.

\$\endgroup\$
  • 1
    \$\begingroup\$ §5.2.4.2.1 in the C99 standard defines INT_MIN to be the "minimum value for an object of type int" and INT_MAX to be the "maximum value for an object of type int". \$\endgroup\$ – Gareth Rees Dec 11 '13 at 23:20
  • 1
    \$\begingroup\$ Yes, that's right. Typical values are INT_MIN = −2^32 = −2147483648 and INT_MAX = 2^32 − 1 = 2147483647, but the values can vary depending on your processor and compiler, so the only way to make code portable is to use the macros. \$\endgroup\$ – Gareth Rees Dec 11 '13 at 23:27
  • 1
    \$\begingroup\$ @Jamal Actually, with <limits>. std::numeric_limits<int>::min() and std::numeric_limits<int>::max() to be precise. \$\endgroup\$ – Yuushi Dec 12 '13 at 0:16
  • 2
    \$\begingroup\$ It's worth pointing out that integer overflow and underflow are undefined only for SIGNED types. For unsigned integers, overflow safely occurs as modulo arithmetic. \$\endgroup\$ – Matt Dec 12 '13 at 12:02
  • 1
    \$\begingroup\$ @Max: That would have undefined behaviour if a + b overflowed, and undefined behaviour is what we are trying to avoid! (But also, even if a + b were defined, your expression could not work, because a + b is an int, and all values of int are less than or equal to INT_MAX.) \$\endgroup\$ – Gareth Rees Dec 13 '13 at 13:36
5
\$\begingroup\$

Simpler method to detect int overflow...

The two simplest methods I know are:

SafeInt was written by David LeBlanc, and Microsoft uses it. safe_iop was written by ???, and Android uses it.


The next simplest method is to use a compiler intrinsic. Unfortunately, I have not seen many of them. I believe I saw some for GCC recently.

The neat thing about intrinsics are (1) they provide a familiar C function call and (2) they are not bound by the Undefined Behavior you are trying to avoid. That means an instrinsic can perform the addition and the program will still be well defined, even it it overflows.

(In C/C++, if you perform the addition and it overflows, then the program is illegal. You are not allowed to perform the operation and then check the result).


The next simplest method is assembly and inline assembly. Again, its not bound by the Undefined Behavior you are trying to avoid in C/C++.

Assembly and inline assembly routines are the method I use. I work on mobile platforms and I have a library for i686, x86_64, ARM and MIPS.

I learned a long time ago its a pain in the butt to try and do this cross-platform in a well defined, portable and efficient manner from C, especially for some operations.

I was constantly checking results of compilations and starring at disassembled code to make sure the code generation was good. So I abandoned portable in the name of simplicity and efficiency.


Also see How to detect integer overflow in C/C++? on Stack Overflow.

\$\endgroup\$
0
\$\begingroup\$

Overflow and underflow can happen in two cases : either

  1. Both negative numbers and sum becomes positive or
  2. Both positive numbers and sum becomes negative.

Then you can use this logical expression:

     ((a<0)&&(b<0)&&(a+b>0)) || ((a>0)&&(b>0)&&(a+b<0))

or if you prefer integer arithmetics to logical expressions:

     (a<0)*(b<0)*(a+b>0) + (a>0)*(b>0)*(a+b<0)

In two complements one can be pedantic and just pick out the sign bit to do operations on, or even in hardware.

\$\endgroup\$
  • \$\begingroup\$ That's not exactly portable, given that you're invoking Undefined Behaviour and then attempting a test for it afterwards. This solution fails in systems with saturating arithmetic, for example. \$\endgroup\$ – Toby Speight Sep 19 '17 at 10:04
  • \$\begingroup\$ @TobySpeight : Yes you are right. I guess I haven't worked enough with those saturating arithmetics to think about it automatically. We can do some constant compile time tests from the start to determine that and use macros to decide if to compile our code or the saturated code. \$\endgroup\$ – mathreadler Sep 19 '17 at 10:29
-2
\$\begingroup\$

Why not use a long to hold the result of the calculation? Then the long can be checked against the (int) MAX and MIN values to see if overflow or underflow occurred? If no violations have occurred, then the result can safely be re-cast back to an (int).

Or, is this too simple and I'm missing something very fundamental? One thing that I HAVE omitted is the possibility that the long will also overflow.

\$\endgroup\$
  • 4
    \$\begingroup\$ As type long is only guaranteed to be at least the range of int, converting to long may not provide any additional range. Thus the problem is fundamentally the same for long as for int. Same situation for long long. \$\endgroup\$ – chux - Reinstate Monica Jul 6 '14 at 17:18
  • \$\begingroup\$ While it's is technically true that long long is only guaranteed to be at least as long as int, I'm not aware of any platform that actually implements long long using the same number of bytes as int. So in practice, this solution just works, plus it's much simpler. \$\endgroup\$ – Samuel Li Mar 25 at 5:29

protected by Jamal Jan 2 '17 at 6:37

Thank you for your interest in this question. Because it has attracted low-quality or spam answers that had to be removed, posting an answer now requires 10 reputation on this site (the association bonus does not count).

Would you like to answer one of these unanswered questions instead?

Not the answer you're looking for? Browse other questions tagged or ask your own question.