More efficient version of an ID calculator in JavaScript

Question

The following function takes two numbers that are linked with a "user" and calculates an ID number based on that. I have been trying to make this as clean as possible, and would like some advice on how to make this more efficient. an example of the input would be "12195491" for the num and "3120" for the ts, which would output "8511"

function getidnumber(num, ts) {
            num = num.substr(4, 4);
            ts = ((ts == undefined) ? "3452" : (ts));
            var _local5 = "";
            var _local1 = 0;
            while (_local1 < num.length) {
                var _local4 = Number(num.substr(_local1, 1));
                var _local3 = Number(ts.substr(_local1, 1));
                var _local2 = String(_local4 + _local3);
                _local5 = _local5 + _local2.substr(_local2.length - 1);
                _local1++;
            }
            return("@user" + _local5);
};

Answer 1

Here's a better implementation.

Used the unary + operator for number conversion.

Used null instead of undefined since it's shorter and produces the same result because of type coersion.

Avoid performing a substring operation by starting to iterate from index 4.

Cached num.length into len so that we save on property lookups when the condition is evaluated for every loop iteration.

Removed uneeded parenthesis.

Took advantage of the += operator.

Made sure that every variables were locally scoped. The _local1 variable in the selected answer isin't properly scoped.

Used a single var statement; it's a better practice to declare variables at the top of the function for readability.

Stole the % 10 idea from the other answer since I thought it was great ;)

 function getidnumber (num, ts) {
    var i = 4, 
        len = num.length,
        res = '@user';

    ts = ts == null? '3452' : ts;

    for (; i < len; i++) {
        res += (+num[i] + +ts[i - 4]) % 10;
    }

    return res;
}

Answer 2

I think this is a little simpler. These are the changes I'd recommend:

1) Always use a for loop if you have an initialization, test, and increment.

2) I'd prefer variable names that have meaning like _nextDigit

3) Take advantage of the fact that strings can be accessed using the array [] operator

4) Made it explicit that we are taking a single digit by using the modulus operator % 10 instead of using _local2.substr(_local2.length - 1).

5) There was too much switching between strings and numbers; only use numbers for modulus and addition.

6) I didn't rename _local5 but we should probably call it resultString or idNumber depending on what you consider it to be.

function getidnumber(num, ts) {
    num = num.substr(4, 4);
    ts = ((ts == undefined) ? "3452" : (ts));
    var _local5 = "";
    for (var _local1 = 0; _local1 < num.length; ++_local1) {
        var _nextDigit = (Number(num[_local1]) + Number(ts[_local1])) % 10;
        _local5 = _local5 + _nextDigit;
    }
    return ("@user" + _local5);
};

Answer 3

Another option using maths instead of string operations.

function getIdNumber(num, ts) {
    var r = '';
    ts = (ts === undefined ? 3452 : ts);
    for (var i = 1; i <= 1000; i *= 10) {
        r = (Math.floor(num / i) + Math.floor(ts / i)) % 10 + r;
    }
    return '@user' + r;
}

or similarly

function getIdNumber(num, ts) {
    var r = '';
    ts = (ts === undefined ? 3452 : ts);
    for (var i = 0; i < 4; i++) {
        r = (Math.floor(num) + Math.floor(ts)) % 10 + r;
        num /= 10;
        ts /= 10;
    }
    return '@user' + r;
}