0
\$\begingroup\$

How might I refactor this to get rid of all the if-else?

  def self.dispatches_for(object)
    scope = Dispatch.asc(:days)
    if object.class == Habit
      scope.where(:habit=>object).map{|d|d}
    elsif object.class == User
      scope.where(:coach=>object).map{|d|d}
    elsif object.class == Content
      scope.where(:content=>object).map{|d|d}
    end
  end
\$\endgroup\$
2
\$\begingroup\$
def self.dispatches_for(object)
  klass = object.class.to_s.downcase.to_sym
  raise "unacceptable class" unless klass.in? [:habit, :coach, :content]
  scope = Dispatch.asc(:days)
  scope.where(klass=>object).map{|d|d}
end
\$\endgroup\$
  • \$\begingroup\$ Also, if you're using ActiveRecord or similar you can do scope.where(klass=>object).to_a instead of map{|d|d}. \$\endgroup\$ – kardeiz Sep 3 '13 at 16:47
  • \$\begingroup\$ @kardeiz, yes, nice point. I'm not sure what is the usage so I refactored the logic only. \$\endgroup\$ – Billy Chan Sep 3 '13 at 16:50

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.