I am working on a C#.Net application that will generate an Excel report from a template. Although the code's not in the app yet, it will pull data from a SQL Server database to populate the report.
I am asking for help in reviewing my class design. My code is below, with some details of the functions removed for simplicity (if someone feels like they need to see them in order to help, I can add them).
using System;
namespace RGBBProgramSummary
{
class Program
{
static void Main()
{
ReportSheet ProgramSummary = new ReportSheet("Program Summary");
ProgramSummary.CleanUp();
}
}
}
using System;
using System.IO;
using System.Runtime.InteropServices;
using Microsoft.Office.Interop.Excel;
namespace RGBBProgramSummary
{
class ReportBook
{
public bool Error;
public DateTime RunDate;
private string FileName;
static Application ExcelApp = new Application();
public Workbooks reportWBs = ExcelApp.Workbooks;
public Workbook ReportWB;
public ReportBook()
{
RunDate = GetRunDate();
FileName = GetFileName(RunDate);
File.Copy(Properties.Settings.Default.Template, FileName);
ReportWB = reportWBs.Open(FileName);
//ExcelApp.Visible = true;
}
private DateTime GetRunDate()
{
...
return DateTime.Now.AddDays(-(int)DateTime.Now.DayOfWeek - 2);
}
private String GetFileName(DateTime RunDate)
{
string FileName;
...
return Properties.Settings.Default.ReportPath + FileName;
}
}
}
using System;
using System.Globalization;
using System.Collections.Generic;
using System.Runtime.InteropServices;
using Microsoft.Office.Interop.Excel;
namespace RGBBProgramSummary
{
class ReportSheet : ReportBook
{
private Worksheet reportWS;
public ReportSheet(string SheetName)
{
reportWS = ReportWB.Worksheets[SheetName];
BuildHeader(reportWS);
}
public void CleanUp()
{
ReportWB.Save();
ReportWB.Close();
Marshal.ReleaseComObject(reportWS);
Marshal.ReleaseComObject(reportWBs);
Marshal.ReleaseComObject(ReportWB);
}
private void BuildHeader(Worksheet WS)
{
int WeekColumn = 0;
int MonthColumn = 0;
...
int j = CountOfWeeks();
...
List<string> MonthList = GetMonthList();
...
}
private int CountOfWeeks()
{
int RunDateWeek
int FirstDateWeek
...
return RunDateWeek - FirstDateWeek + 1;
}
private List<string> GetMonthList()
{
List<string> MonthList = new List<string>();
...
return MonthList;
}
}
}
As you can see, I really only have 2 classes. ReportBook represents the Workbook itself, and ReportSheet represents the Worksheet (ReportSheet inherits from ReportBook). I'm wondering if that's overkill, and really if they should be consolidated into one class. At the least, I would need to make changes if I ever wanted to add an additional worksheet (for one, I wouldn't want to open the workbook in the constructor of the base class then).
Also, I was going create a function in the ReportSheet class to read from the aforementioned SQL DB. But, after reading answers to another question, I'm thinking that the read from the DB should be in it's own class.
