1
\$\begingroup\$

I want to abstract away differences between zipfile and rarfile modules. In my code i want to call ZipFile or RarFile constructors depending on file format. Currently i do it like that.

def extract(dir, f, archive_type):
    '''
    archive_type should be 'rar' or 'zip'
    '''
    images = []

    if archive_type == 'zip':
        constructor = zipfile.ZipFile
    else:
        constructor = rarfile.RarFile

    with directory(dir):
        with constructor(encode(f)) as archive:
            archive.extractall()
        os.remove(f)
        images = glob_recursive('*')

    return images

Is there any more elegant way for dynamic object calling?

\$\endgroup\$

1 Answer 1

4
\$\begingroup\$

Classes are first-class objects in Python.

amap = {
  'zip': zipfile.ZipFile,
  'rar': rarfile.RarFile
}

 ...

with amap[archive_type](encode(f)) as archive:
   ...

or

with amap.get(archive_type, rarfile.RarFile)(encode(f)) as archive:
   ...
\$\endgroup\$

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.