Beginner bank app withdrawal transaction

Question

Pooja would like to withdraw X USD from an ATM. The cash machine will only accept the transaction if X is a multiple of 5, and Pooja's account balance has enough cash to perform the withdrawal transaction (including bank charges). For each successful withdrawal, the bank charges 0.50 USD. Calculate Pooja's account balance after an attempted transaction.

Please review my code.

   var x= parseInt(prompt("put the value of account balance"));
  var y=parseInt(prompt("put the value of widrawal cash "));
     const charges=0.50;

      if(y%5==0 && y<x)
    {
alert((x-y)-charges)
            }else
   {
           alert(x)
      }

Answer 1

From a short review;

• If you are not going to change the value of a variable, use const, not var
• Avoid spelling mistakes; widrawal -> withdrawal
• The if statement does not take the charges in to account
• The indentation of this code is bad, please consider using a js formatter
• alert and prompt are considered only okay for the most basic exercises
• x and y are very poor names, how about accountBalance and requestedAmount?

This is my counter proposal

function performWithdrawal(){
  const accountBalance = parseInt(prompt("What is the value of the account balance?"));
  const requestedAmount = parseInt(prompt("How much do you wish to withdraw?"));
  const withdrawalCharges = 0.5;

  if(requestedAmount % 5 == 0 && (requestedAmount + withdrawalCharges <= accountBalance)){
    alert(`Your new bank account balance is ${accountBalance - requestedAmount - withdrawalCharges}`)
  } else {
    alert(`Your bank account balance is too low to withdraw ${requestedAmount} USD`);
  }    
}

Answer 2

There is no reason that the amounts have to be integers. By using parseInt(), you end up truncating the decimal portion of the input, which is wrong.