Finding the string from the list of array objects

Question

TA.ServiceProxy.RoleManagement.GetSubPrivilagesResponses subPrivilagesResponses = GetSubPrivilagesFromPrivilageCodeStatic("Authoring01");
if (subPrivilagesResponses != null && subPrivilagesResponses.SubprivilagesList != null)
{
    for (int j = 0; j < subPrivilagesResponses.SubprivilagesList.Length; j++)
    {
       if (subPrivilagesResponses.SubprivilagesList[j].PrivilageCode == "CREATOR")
       {
           objTemplate.IsTagged = true;
           break;
       }
    }
}

The above code is written as

TA.ServiceProxy.RoleManagement.GetSubPrivilagesResponses subPrivilagesResponses = GetSubPrivilagesFromPrivilageCodeStatic("Authoring01");
if (subPrivilagesResponses != null && subPrivilagesResponses.SubprivilagesList != null)
{
   var item = subPrivilagesResponses.SubprivilagesList.SingleOrDefault(cd => cd.PrivilageCode == "CREATOR");
    if(item != null && item.PrivilageCode == "CREATOR")
        objTemplate.IsTagged = true;                              
}

In what are the different way it can be modified in order to boost performance and efficiency by making use of Lambda or LINQ

Answer 1

Because the question is about performance and efficiency that's why some sort of benchmarking would be essential to compare different implementations. I have found BenckmarkDotNet really useful for these kind of experiments.

You can define the for loop version as your baseline and the tool will compare the other implementation against that. Here is my simplified example how to setup your environment for measurement:

[HtmlExporter]
[MemoryDiagnoser]
[SimpleJob(BenchmarkDotNet.Engines.RunStrategy.ColdStart, targetCount: 100)]
public class IterationOptimalizationExperiment
{
    private static List<Data> target;
    private const string TheOne = "TheOne";

    [GlobalSetup]
    public void Setup()
    {
        target = Enumerable.Range(0, 10000)
            .Select(i => new Data { Id = i, Type = i % 7777 == 0 ? TheOne : "NotTheOne" })
            .ToList();
    }

    [Benchmark(Baseline = true)]
    public void WithFor()
    {
        bool hasFound = false;
        for (int i = 0; i < target.Count; i++)
            if (string.Equals(target[i].Type, TheOne, StringComparison.OrdinalIgnoreCase))
            {
                hasFound = true;
                break;
            }

    }

    [Benchmark]
    public void WithForEach()
    {
        bool hasFound = false;
        foreach (var t in target)
            if (string.Equals(t.Type, TheOne, StringComparison.OrdinalIgnoreCase))
            {
                hasFound = true;
                break;
            }
    }

    [Benchmark]
    public void WithAny()
    {
        bool hasFound = target.Any(t => string.Equals(t.Type, TheOne, StringComparison.OrdinalIgnoreCase));
    }
}

And you should simply call the following command to start your experiment: BenchmarkRunner.Run<IterationOptimalizationExperiment>();

When you run it in Release mode it will dump something like this:

Answer 2

If you're using C#6 or above, you can use the null conditional operator ?.:

var hasCreator = GetSubPrivilagesFromPrivilageCodeStatic("Authoring01")?.SubprivilagesList?.Any(cd => cd.PrivilageCode == "CREATOR") ?? false;
if (hasCreator) 
{
    objTemplate.IsTagged = true;
}

If it's not too late, I'd correct the spelling of privilege in your code. I misspelt latitude (as lattitude) in some key js once and frustrated my colleagues for years.

Answer 3

The only think that comes to my mind is to rewrite this:

var item = subPrivilagesResponses.SubprivilagesList.SingleOrDefault(cd => cd.PrivilageCode == "CREATOR");
    if(item != null && item.PrivilageCode == "CREATOR")
        objTemplate.IsTagged = true;    

into this:

if (subPrivilagesResponses.SubprivilagesList.Any(cd => cd.PrivilageCode == "CREATOR"))
        objTemplate.IsTagged = true;