I made a C# console math project where the user answers addition, subtraction, multiplication, division, power or square-root questions based on the difficulty they choose!
However, I am struggling to refactor one part of my code.
Here is my code:
using System;
using System.Collections.Generic;
namespace mathstester
{
class Program
{
public enum UserDifficulty
{
Easy,
Normal,
Hard
}
public enum MathOperation
{
Addition = 1,
Subtraction = 2,
Multiplication = 3,
Division = 4,
Power = 5,
SquareRoot = 6
}
public static (int operationMin, int operationMax) GetPossibleOperationsByDifficulty(UserDifficulty userDifficulty)
{
switch (userDifficulty)
{
case UserDifficulty.Easy:
return (1, 4);
case UserDifficulty.Normal:
return (1, 5);
case UserDifficulty.Hard:
return (3, 7);
default:
throw new Exception();
}
}
public static (string message, double correctAnswer) GetMathsEquation(MathOperation mathOperation, UserDifficulty userDifficulty)
{
int number1;
int number2;
Random randomNumber = new Random();
switch (mathOperation)
{
case MathOperation.Addition:
number1 = randomNumber.Next(1000);
number2 = randomNumber.Next(1000);
return ($"{number1} + {number2}", number1 + number2);
case MathOperation.Subtraction:
number1 = randomNumber.Next(1000);
number2 = randomNumber.Next(1000);
return ($"{number1} - {number2}", number1 - number2);
case MathOperation.Multiplication:
number1 = userDifficulty == UserDifficulty.Easy ? randomNumber.Next(13) : randomNumber.Next(1000);
number2 = userDifficulty == UserDifficulty.Easy ? randomNumber.Next(13) : randomNumber.Next(1000);
return ($"{number1} * {number2}", number1 * number2);
case MathOperation.Division:
number1 = randomNumber.Next(10000);
number2 = randomNumber.Next(1000);
return ($"{number1} / {number2}", number1 / (double)number2);
case MathOperation.Power:
number1 = randomNumber.Next(13);
number2 = randomNumber.Next(5);
return ($"{number1} ^ {number2}", Math.Pow(number1, number2));
case MathOperation.SquareRoot:
number1 = randomNumber.Next(1000);
return ($"√{number1}", Math.Sqrt(number1));
default:
throw new Exception();
}
}
public class OperationQuestionScore
{
public int AdditionQuestion { get; set; }
public int AdditionScore { get; set; }
public int SubtractionQuestion { get; set; }
public int SubtractionScore { get; set; }
public int MultiplicationQuestion { get; set; }
public int MultiplicationScore { get; set; }
public int DivisionQuestion { get; set; }
public int DivisionScore { get; set; }
public int PowerQuestion { get; set; }
public int PowerScore { get; set; }
public int SquareRootQuestion { get; set; }
public int SquareRootScore { get; set; }
}
public static OperationQuestionScore Score()
{
return new OperationQuestionScore();
}
public static (int, OperationQuestionScore, OperationQuestionScore) RunTest(int numberOfQuestionsLeft, UserDifficulty userDifficulty)
{
int totalScore = 0;
Random random = new Random();
var (operationMin, operationMax) = GetPossibleOperationsByDifficulty(userDifficulty);
var score = Score();
var question = Score();
while (numberOfQuestionsLeft > 0)
{
int mathRandomOperation = random.Next(operationMin, operationMax);
MathOperation mathOperation = (MathOperation)mathRandomOperation;
var (message, correctAnswer) = GetMathsEquation(mathOperation, userDifficulty);
if (mathRandomOperation == 4 || mathRandomOperation == 6)
{
Console.Write($"To the nearest integer, What is {message} =");
}
else
{
Console.Write($"What is {message} =");
}
double userAnswer = Convert.ToDouble(Console.ReadLine());
if (Math.Round(correctAnswer) == userAnswer)
{
Console.WriteLine("Well Done!");
switch (mathOperation)
{
case MathOperation.Addition:
question.AdditionQuestion++;
score.AdditionScore++;
break;
case MathOperation.Subtraction:
question.SubtractionQuestion++;
score.SubtractionScore++;
break;
case MathOperation.Multiplication:
question.MultiplicationQuestion++;
score.MultiplicationScore++;
break;
case MathOperation.Division:
question.DivisionQuestion++;
score.DivisionScore++;
break;
case MathOperation.Power:
question.PowerQuestion++;
score.PowerScore++;
break;
case MathOperation.SquareRoot:
question.SquareRootQuestion++;
score.SquareRootScore++;
break;
}
totalScore++;
}
else
{
Console.WriteLine("Your answer is incorrect!");
switch (mathOperation)
{
case MathOperation.Addition:
question.AdditionQuestion++;
break;
case MathOperation.Subtraction:
question.SubtractionQuestion++;
break;
case MathOperation.Multiplication:
question.MultiplicationQuestion++;
break;
case MathOperation.Division:
question.DivisionQuestion++;
break;
case MathOperation.Power:
question.PowerQuestion++;
break;
case MathOperation.SquareRoot:
question.SquareRootQuestion++;
break;
}
}
numberOfQuestionsLeft--;
}
return (totalScore, score, question);
}
public static void Main(string[] args)
{
Dictionary<string, UserDifficulty> difficultyDictionary = new Dictionary<string, UserDifficulty>();
difficultyDictionary.Add("E", UserDifficulty.Easy);
difficultyDictionary.Add("N", UserDifficulty.Normal);
difficultyDictionary.Add("H", UserDifficulty.Hard);
string userInputDifficulty = "";
do
{
Console.WriteLine("What difficulty level would you like to do! Please type E for Easy, N for Normal and H for hard");
userInputDifficulty = Console.ReadLine().ToUpper();
} while (userInputDifficulty != "E" && userInputDifficulty != "N" && userInputDifficulty != "H");
UserDifficulty userDifficulty = difficultyDictionary[userInputDifficulty];
int numberOfQuestions = 0;
do
{
Console.WriteLine("How many questions would you like to answer? Please type a number divisible by 10!");
int.TryParse(Console.ReadLine(), out numberOfQuestions);
} while (numberOfQuestions % 10 != 0);
var (totalScore, score, question) = RunTest(numberOfQuestions, userDifficulty);
Console.WriteLine($"Total score: {totalScore} of {numberOfQuestions}");
if (userDifficulty == UserDifficulty.Easy)
{
Console.WriteLine($"Addition score: {score.AdditionScore} of {question.AdditionQuestion}");
Console.WriteLine($"Subtraction score: {score.SubtractionScore} of {question.SubtractionQuestion}");
Console.WriteLine($"Multiplication score: {score.MultiplicationScore} of {question.MultiplicationQuestion}");
}
else if (userDifficulty == UserDifficulty.Normal)
{
Console.WriteLine($"Addition score: {score.AdditionScore} of {question.AdditionQuestion}");
Console.WriteLine($"Subtraction score: {score.SubtractionScore} of {question.SubtractionQuestion}");
Console.WriteLine($"Multiplication score: {score.MultiplicationScore} of {question.MultiplicationQuestion}");
Console.WriteLine($"Division score: {score.DivisionScore} of {question.DivisionQuestion}");
}
else if (userDifficulty == UserDifficulty.Hard)
{
Console.WriteLine($"Multipication score: {score.MultiplicationScore} of {question.MultiplicationQuestion}");
Console.WriteLine($"Division score: {score.DivisionScore} of {question.DivisionQuestion}");
Console.WriteLine($"Power score: {score.PowerScore} of {question.PowerQuestion}");
Console.WriteLine($"Squareroot score: {score.SquareRootScore} of {question.SquareRootQuestion}");
}
}
}
}
In my "RunTest" function I've got two "switch" statements inside an "if-else" statement. Without changing my code too much, I want to shorten the code by using only one "switch" statement inside my "if-else" statement.
I need help refactoring my code so I don't have so many loops inside a loop.