4
\$\begingroup\$

I'm learning javascript with discord.js and node and I'm always looking for the "best" code.

Is this the "best code" for my map() ? ([role] required, (role) optional)

// Get [role] (@role) args
let roles = msg.mentions.roles.filter(role => (args[2] === `<@&${role.id}>` || args[3] === `<@&${role.id}>`)).map(role => {
  nbArgs++;
  return role.id;
});

// Get text
let txtContent = msg.content.split(/ +/g).splice(nbArgs).join(' ');
\$\endgroup\$

1 Answer 1

1
\$\begingroup\$

Maybe this is better :

let roles = msg.mentions.roles.filter(role => (args[2] === role.toString() || args[3] === role.toString())).map(role => role.id);

And use roles.length instead of nbArgs++ :

// Get text
let txtContent = msg.content.split(/ +/g).splice(roles.length + nbArgs).join(' ');
\$\endgroup\$

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.