0
\$\begingroup\$

2 weeks ago I passed a technical test for the job of a frontend developer so they give me a screenshot of a typical form and I need to code it by HTML/CSS and they request a small animation with javascript the test was 6 hours I completed it in 40 min I thought it was ok, today I get a feedback that I was rejected because I need to ameliorate my coding skills, noting that I used code existing in many platforms like Codepen. I am looking for any feedback. Maybe I'm integrating in HTML in a wrong way.

      <ul class="tab-group">
        <li class="tab active"><a href="#signup">Registro</a></li>
        <li class="tab"><a href="#login">Acceso</a></li>
      </ul>

      <div class="tab-content">
        <div id="signup">   

          <form action="/" method="post">

          <div class="top-row">

            <div class="field-wrap">
            <label>
              myHF ID<span class="req">*</span>
            </label>
            <input type="text"required autocomplete="off"/>
          </div>

            <div class="field-wrap">
              <label>
                Nombre<span class="req">*</span>
              </label>
              <input type="text" required autocomplete="off" />
            </div>

            <div class="field-wrap">
              <label>
                Apellido<span class="req">*</span>
              </label>
              <input type="text"required autocomplete="off"/>
            </div>
          </div>


          <div class="field-wrap">
            <label>
              Correo electrónico<span class="req">*</span>
            </label>
            <input type="email"required autocomplete="off"/>
          </div>

            <div class="field-wrap">
            <label>
              Teléfono<span class="req">*</span>
            </label>
            <input type="text"required autocomplete="off"/>
          </div>

            <div class="field-wrap">
            <label>
              País<span class="req">*</span>
            </label>
            <input type="text"required autocomplete="off"/>
          </div>

            <div class="field-wrap">
            <label>
              Patrocinador ID<span class="req">*</span>
            </label>
            <input type="text"required autocomplete="off"/>
          </div>

          <div class="field-wrap">
            <label>
              Contraseña<span class="req">*</span>
            </label>
            <input type="password"required autocomplete="off"/>
          </div>

          <button type="submit" class="button button-block"/>Empecemos</button>

          </form>

        </div>

        <div id="login">   
          <h1>Bienvenido de vuelta</h1>

          <form action="/" method="post">

            <div class="field-wrap">
            <label>
              myHF ID<span class="req">*</span>
            </label>
            <input type="text"required autocomplete="off"/>
          </div>

          <div class="field-wrap">
            <label>
              Contraseña<span class="req">*</span>
            </label>
            <input type="password"required autocomplete="off"/>
          </div>

          <p class="forgot"><a href="#">¿Olvidaste tu contraseña?</a></p>

          <button class="button button-block"/>Ingresar</button>

          </form>

        </div>

      </div><!-- tab-content -->

</div> <!-- /form -->

@import "compass/css3";

$body-bg: #c1bdba;
$form-bg: #13232f;
$white: #ffffff;

$main: #1ab188;
$main-light: lighten($main,5%);
$main-dark: darken($main,5%);

$gray-light: #a0b3b0;
$gray: #ddd;

$thin: 300;
$normal: 400;
$bold: 600;
$br: 4px;

*, *:before, *:after {
  box-sizing: border-box;
}

html {
    overflow-y: scroll; 
}

body {
  background:$body-bg;
  font-family: 'Titillium Web', sans-serif;
}

a {
  text-decoration:none;
  color:$main;
  transition:.5s ease;
  &:hover {
    color:$main-dark;
  }
}

.form {
  background:rgba($form-bg,.9);
  padding: 40px;
  max-width:600px;
  margin:40px auto;
  border-radius:$br;
  box-shadow:0 4px 10px 4px rgba($form-bg,.3);
}

.tab-group {
  list-style:none;
  padding:0;
  margin:0 0 40px 0;
  &:after {
    content: "";
    display: table;
    clear: both;
  }
  li a {
    display:block;
    text-decoration:none;
    padding:15px;
    background:rgba($gray-light,.25);
    color:$gray-light;
    font-size:20px;
    float:left;
    width:50%;
    text-align:center;
    cursor:pointer;
    transition:.5s ease;
    &:hover {
      background:$main-dark;
      color:$white;
    }
  }
  .active a {
    background:$main;
    color:$white;
  }
}

.tab-content > div:last-child {
  display:none;
}


h1 {
  text-align:center;
  color:$white;
  font-weight:$thin;
  margin:0 0 40px;
}

label {
  position:absolute;
  transform:translateY(6px);
  left:13px;
  color:rgba($white,.5);
  transition:all 0.25s ease;
  -webkit-backface-visibility: hidden;
  pointer-events: none;
  font-size:22px;
  .req {
    margin:2px;
    color:$main;
  }
}

label.active {
  transform:translateY(50px);
  left:2px;
  font-size:14px;
  .req {
    opacity:0;
  }
}

label.highlight {
    color:$white;
}

input, textarea {
  font-size:22px;
  display:block;
  width:100%;
  height:100%;
  padding:5px 10px;
  background:none;
  background-image:none;
  border:1px solid $gray-light;
  color:$white;
  border-radius:0;
  transition:border-color .25s ease, box-shadow .25s ease;
  &:focus {
        outline:0;
        border-color:$main;
  }
}

textarea {
  border:2px solid $gray-light;
  resize: vertical;
}

.field-wrap {
  position:relative;
  margin-bottom:40px;
}

.top-row {
  &:after {
    content: "";
    display: table;
    clear: both;
  }

  > div {
    float:left;
    width:48%;
    margin-right:4%;
    &:last-child { 
      margin:0;
    }
  }
}

.button {
  border:0;
  outline:none;
  border-radius:0;
  padding:15px 0;
  font-size:2rem;
  font-weight:$bold;
  text-transform:uppercase;
  letter-spacing:.1em;
  background:$main;
  color:$white;
  transition:all.5s ease;
  -webkit-appearance: none;
  &:hover, &:focus {
    background:$main-dark;
  }
}

.button-block {
  display:block;
  width:100%;
}

.forgot {
  margin-top:-20px;
  text-align:right;
}
\$\endgroup\$
  • \$\begingroup\$ "a technical test" Please include more details about this test, so we can check whether you've implemented it right and look for obvious inefficiencies. Now we're missing a challenge description, which makes it a lot harder to write a decent review. \$\endgroup\$ – Mast Aug 16 '19 at 9:26
  • \$\begingroup\$ this is the Link of the screenshot of the template: ibb.co/XJnKkZS i need just to know if there is a way to improve the code \$\endgroup\$ – Med Khalil Rahmouni Aug 16 '19 at 9:27
  • 1
    \$\begingroup\$ "noting that I used code existing in many platforms like Codepen" Did they note this or do you note this? Did you write at least a decent amount of it yourself or is it a copy-paste pasta of other projects? Do you understand how and why it works? \$\endgroup\$ – Mast Aug 16 '19 at 9:27
  • \$\begingroup\$ No links please, embed all information in the question itself. Links can rot. \$\endgroup\$ – Mast Aug 16 '19 at 9:28
  • \$\begingroup\$ Cross-posted on Stack Overflow \$\endgroup\$ – Mast Aug 16 '19 at 9:28

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Browse other questions tagged or ask your own question.