In the situation where I am looping through a collection looking for an item, is it better practice to break
before I return
or should I break
and then return
?
Return during loop:
foreach(string item in items)
{
string[] split = item.Split('|');
if(split[0] == searchFor)
return split[1];
}
return null;
Break then return:
string result = null;
foreach(string item in items)
{
string[] split = item.Split('|');
if(split[0] == searchFor)
{
result = split[1];
break;
}
}
return result;
return (from split in items.Select(item => item.Split('|')) where split[0] == searchFor select split[1]).FirstOrDefault();
\$\endgroup\$return (from item in items where item.StartsWith(searchFor + '|') select item.Split('|')[1]).FirstOrDefault();
is even shorter — but is it more readable? Doubtful. \$\endgroup\$