1
\$\begingroup\$

This is my code:

#include <stdio.h>
#include <ctype.h>

int main()

{
    int ch;
    int numberOfCharacters = 0;
    printf("please enter a word, and ctrl + d to see the resault\n");

    while ((ch = getchar()) != EOF && isprint(ch))

    {
        numberOfCharacters++;
    }

    printf("The number of characters is %d", numberOfCharacters);

    return 0;
}

Is this a good code?

\$\endgroup\$
1
\$\begingroup\$

Well, it doesn't do much. But it is not bad. A few issues:

  • main() should have parameters
  • excess blank lines (lines 5, 12, 16, 18) spoil the appearance
  • no \n on the last printf
  • the spec doesn't say 'printable' characters, just characters.
  • "please" needs a capital p and "resault" should be "result"
\$\endgroup\$
  • \$\begingroup\$ thank you! i know it dosent do much, but since im a newbie i would love to get feedback like you just wrote so i will know for next time or when i have bigger programs @WilliamMorris \$\endgroup\$ – MNY Feb 1 '13 at 13:54

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.