Just a simple pagination "for" loop [closed]

Question

for ($i = ($pagcurrent >= 5 ? $pagcurrent - 4 : $pagcurrent); $i <= ($paglast < $pagcurrent + 4 ? $paglast : $pagcurrent + 4); $i++) {
    if ($i == $pagcurrent) {
        echo "<li class='current'>" . $i . "</li>";
    }
    else {
        echo "<li><a href='?page=" . $i . "&searchPlayername=" . $searchPlayername . "&searchSteamid=" . $searchSteamid . "&searchServer=" . $searchServer . "'>" . $i . "</a></li>";
    }
}

So, this is basically what I have managed to do so far, but I was concerned whether i was skipping pages and whether the page with the "current" class is not actually the real page, idk, just concerned a bit, and since Im not very good at loops, i wanted someone to check if the code is good or not, and any suggestions if you have.

Answer 1

Here's an example of a neater way to do what you're trying to do..

// Number of pages to display
$pagesToDisplay = 10;

// First page to display
$start = $pagcurrent;
if($start >= 1) $start = $start - ($paglast % $pagesToDisplay);

// Last page to display (if it exists)
$end = $start + $pagesToDisplay;

// Loop until there is nothing left to loop thru OR the maximum number of pages has been looped
for ($i = $start; $i < $end && $i <= $paglast; $i++) { ... }

Here's a fully working example: https://3v4l.org/N7bXj

This is neater and much easier to manage.

Answer 2

slightly changed a few conditions from another code

$dots = false;
for ( $i=1; $i<=$paglast; $i++ ) {
    if( $i == $pagcurrent ) {
        echo "<li class='current'><a>" . $i . "</a></li>";
    } else {
        if ( ( $pagcurrent < 5 && $i < 5 ) || ( ( $i > $pagcurrent-4 && $i < $pagcurrent ) || $i > $paglast-2 || $i > $pagcurrent && $i < $pagcurrent+5 ) ) {
            echo "<li><a href='?page=" . $i . "&searchPlayername=" . $searchPlayername . "&searchSteamid=" . $searchSteamid . "&searchServer=" . $searchServer . "'>" . $i . "</a></li>";
        } else {
            if ( $i > $pagcurrent && !$dots ) {
                echo "...";
                $dots = true;
            }
        }
    }
}