4
\$\begingroup\$

How can I DRY these scopes?

  scope :reputed, -> {
    joins{reputations.outer}.
    where{['coalesce(rs_reputations.value, 0) > ? OR purchases.force_active = ?', LOWEST_VOTE, true]}
  }

  scope :reputed_or_mine, ->(user) {
    joins{reputations.outer}.
    where{['coalesce(rs_reputations.value, 0) > ? OR purchases.force_active = ? OR purchases.user_id = ?', LOWEST_VOTE, true, user.id]}
  }
\$\endgroup\$

1 Answer 1

1
\$\begingroup\$
'coalesce(rs_reputations.value, 0) > ? OR purchases.force_active = true OR (? AND purchases.user_id = ?)',
LOWEST_VOTE,
!user.id.nil?,
(if user.id.nil? then -1 else user.id end)

This is semantically equivalent to both, but the AND in the third clause prevents it from having an effect when there is no user.id.

\$\endgroup\$
5
  • \$\begingroup\$ No thanks. It's looks uglier and contains errors. \$\endgroup\$
    – ck3g
    Sep 24, 2012 at 5:44
  • \$\begingroup\$ @ck3g, can you be more specific about the errors? \$\endgroup\$ Sep 24, 2012 at 17:30
  • \$\begingroup\$ Sure. user.id will throw error Undefined method id for NilClass or called id for nil... if user will not passed. Your solution is based on this. \$\endgroup\$
    – ck3g
    Sep 24, 2012 at 23:21
  • \$\begingroup\$ @ck3g, Understood. In that case, I'd declare the user argument with a default value that has an id of nil. \$\endgroup\$ Sep 25, 2012 at 1:04
  • \$\begingroup\$ with OR in there, you don't get much other options. I don't support collecting in several steps and merging afterwards, because that's what a relational database is usually the best at. So I'm upvoting this solution. \$\endgroup\$
    – Simon B.
    Jun 21, 2013 at 6:59

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.