5
\$\begingroup\$

A project I'm working on often has lists within lists within lists etc. The original author often uses complicated linq expressions, but when adapting them I mostly get hopelessly bogged down and resort to foreach's which makes me feel like a lesser being (joke). With an expression such as the following, what would the equivalent Linq expression be, and would you bother taking the time to make it, instead of the 'easy' foreach option.

        var participantList = new List<string>();

        foreach (var community in communities)
        {
            foreach (var tournament in community.Tournaments)
            {
                foreach (var round in tournament.Rounds)
                {
                    foreach (var match in round.Matches)
                    {
                        if (match.Home.ParticipantId.IsNotNull())
                        {
                           participantList.Add(match.Home.ParticipantId); 
                        }
                        if (match.Away.ParticipantId.IsNotNull())
                        {
                           participantList.Add(match.Away.ParticipantId); 
                        }
                    }

                }
            }
        }
\$\endgroup\$
  • 1
    \$\begingroup\$ The desire to improve code is implied for all questions on this site. Question titles should reflect the purpose of the code, not how you wish to have it reworked. See How to Ask. \$\endgroup\$ – Ethan Bierlein Mar 4 '16 at 15:57
8
\$\begingroup\$

The LINQ would be:

var participantList = communities.SelectMany(c => c.Tournaments
                                                   .SelectMany(t => t.Rounds
                                                                     .SelectMany(r => r.Matches)))
                                  .Where(m => m.Home.ParticipantId.IsNotNull() ||
                                              m.Away.ParticipantId.IsNotNull())
                                  .ToList();

LINQ does not add much imo, if the logic was more complicated the for loops are nicer to debug.

One downside with LINQ for this is that it requires formatting to be readable. If you rename things the formatting needs to be maintained.

With the foreach loops you get formatting for free.

Edit: As per @RobH's suggestion:

var participantList = communities.SelectMany(c => c.Tournaments)
                                 .SelectMany(t => t.Rounds)
                                 .SelectMany(r => r.Matches)
                                 .Where(m => m.Home.ParticipantId.IsNotNull() || 
                                             m.Away.ParticipantId.IsNotNull())
                                 .ToList();

Chaining is indeed nicer.

\$\endgroup\$
  • 3
    \$\begingroup\$ +1 You could 'stack' the SelectMany calls instead of nesting them. That can be a bit easier to read. \$\endgroup\$ – RobH Mar 4 '16 at 16:45

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.