Enum Singleton implementation in Java

Question

I just wanted to implement the enum singleton in java. Here is my implementation where I have tried to create a singleton DataSource instance:

public enum EasySingleton {
    INSTANCE;

    private DataSource dataSource;

    private EasySingleton() {
        this.dataSource = MYDB.getDataSource();

    }

    public DataSource getDataSource(){
        return dataSource;
    }

}

and get this DataSource instance just like this:

DataSource dataSource = EasySingleton.INSTANCE.getDataSource();

I just wanted to confirm whether my implementation is correct or not. If it is wrong then please tell me how to implement the enum singleton to create a singleton DataSource instance.

Answer 1

This is not a good use for a enum singleton. What you have there is a wrapper for MYDB.getDataSource(). You could handle that with a static synchronized method.

public class DataSourceAdapter {
    private static DataSource dataSource;
    public static synchronized DataSource getDataSource(){
        if(dataSource == null){
            dataSource = MYDB.getDataSource();
        }
        return dataSource;
    }
}