I have ASP.NET WebApi project. Some of controller has method SetAsMain(int id)
that get information about people then use stored procedure update people. How can I improve it? Should I do check people.IsMain == true
in stored procedure?
public HttpResponseMessage SetAsMain(int id)
{
People people = repository.GetById(id);
if (people == null)
{
return ErrorMsg(HttpStatusCode.NotFound, string.Format("No people with ID = {1}", id));
}
if (people.IsMain == true)
{
return ErrorMsg(HttpStatusCode.OK, string.Format("{0} is already set as main", people.Houses.ToString()));
}
try
{
var parameters = new Dictionary<string, string>();
parameters.Add("PeopleID", id.ToString());
repository.ExecProcedure("usp_PeopleSetMain", parameters);
return Request.CreateResponse(HttpStatusCode.OK, repository.GetById(id)); // some problem here
}
catch (Exception ex)
{
return ErrorMsg(HttpStatusCode.InternalServerError, ex.Message);
}
}
ErrorMsg(HttpStatusCode.OK
-- what is it, an error or not an error? \$\endgroup\$ – BCdotWEB Sep 15 '15 at 9:01ErrorMsg
: I have to create a similar method with other name. Thanks \$\endgroup\$ – Roman Marusyk Sep 15 '15 at 9:29