How to write a cleaner code for this piece of php snippet?

Question

I would like to know if there is a better/shorter/cleaner/resource saving method for this snippet of php code with codeigniter? Thanks.

$code = $this->uri->segment(3);

if (!$code) {
    // validation
    $this->form_validation->set_rules('code', 'PassCode', 'required|trim|max_length[100]|xss_clean');

    // run validation to check if validation rules are satifised
    if ($this->form_validation->run() == true) {
        $code = $this->input->post('code');
        $user_id = $this->user_model->getUserId($code);
        if (empty($user_id)) {
            $data['errorMessage'] = 'Your code is not valid.';
        } else {
            redirect('user/profile');   
        }
    }
} else {
    $user_id = $this->user_model->getUserId($code);
    if (empty($user_id)) {
        $data['errorMessage'] = 'Your code is not valid.';
    } else {
        redirect('user/profile');   
    }
}

Answer 1

if ($this->form_validation->run() == true)

is redundant, just use...

if ($this->form_validation->run())

---

Also, you can move the whole if (empty($user_id)) block outside to the end to avoid duplicating it:

$code = $this->uri->segment(3);

if (!$code) {
    // validation
    $this->form_validation->set_rules('code', 'PassCode',
        'required|trim|max_length[100]|xss_clean');

    // run validation to check if validation rules are satifised
    if ($this->form_validation->run()) {
        $code = $this->input->post('code');
        $user_id = $this->user_model->getUserId($code);
    }
} else {
    $user_id = $this->user_model->getUserId($code);
}

if (empty($user_id)) {
    $data['errorMessage'] = 'Your code is not valid.';
} else {
    redirect('user/profile');   
}