I'm learning about OOP and putting my knowledge into practice.
I created a login system in PHP, so I wish someone could tell me if I'm on the right track. I feel like I'm getting better at coding, but it's never good enough, so I want someone more experienced (especially in OOP) to look at my code and tell me if I'm doing it right and what I can improve.
Just a note, I recognize that the PHP code contained in HTML is not something appropriate, but I just put it to make it easier to understand how the system works. Therefore, I ask you to focus on the login system part, more precisely on OOP.
Tree
Login(directory):.
│ composer.json
│ Dashboard.php
│ Main.php
│ Signin.php
│
├───.idea
│ .gitignore
│ Login.iml
│ modules.xml
│ php.xml
│ workspace.xml
│
├───src
│ HttpTransport.php
│ Login.php
│ Session.php
│ UserAccount.php
│
└───vendor
│ autoload.php
│
└───composer
autoload_classmap.php
autoload_namespaces.php
autoload_psr4.php
autoload_real.php
autoload_static.php
ClassLoader.php
LICENSE
UserAccount.php
<?php
declare(strict_types = 1);
namespace Login;
class UserAccount
{
private string $email;
private string $password;
public function setEmail(string $email): void
{
$this->email = $email;
}
public function getEmail(): string
{
return $this->email;
}
public function setPassword(string $password): void
{
$this->password = $password;
}
public function getPassword(): string
{
return $this->password;
}
}
Session.php
<?php
declare(strict_types = 1);
namespace Login;
class Session
{
public static function startSession(string $sessionName, string $value)
{
return $_SESSION[$sessionName] = $value;
}
}
HttpTransport
<?php
declare(strict_types = 1);
namespace Login;
class HttpTransport
{
public static function setFlashMessage(string $message): string
{
return $message;
}
public static function redirect(string $path): void
{
header('Location: ' . $path);
exit;
}
}
Login.php
<?php
declare(strict_types = 1);
namespace Login;
use \Login\HttpTransport;
use \Login\Session;
class Login
{
public function __construct(public \PDO $conn)
{
}
public function login(UserAccount $user)
{
$sql = "SELECT * FROM users WHERE email = ?";
$statement = $this->conn->prepare($sql);
$statement->execute([
$user->getEmail()
]);
if ($statement->rowCount() > 0)
{
$rows = $statement->fetchAll(\PDO::FETCH_ASSOC);
foreach ($rows as $row)
{
$passwordHash = $row['passwordHash'];
$hash = password_verify($user->getPassword(), $passwordHash);
if ($hash)
{
Session::startSession('username', $row['username']);
HttpTransport::redirect('/login/dashboard.php');
}
else
{
$flashMessage = HttpTransport::setFlashMessage('<p>Incorrect e-mail or password.</p>');
Session::startSession('error', $flashMessage);
HttpTransport::redirect('/login/signin.php');
}
}
}
else
{
$flashMessage = HttpTransport::setFlashMessage('<p>Incorrect e-mail or password.</p>');
Session::startSession('error', $flashMessage);
HttpTransport::redirect('/login/signin.php');
}
}
}
Signin.php
<?php
session_start();
session_regenerate_id(true);
if (isset($_SESSION['username']))
{
header('Location: dashboard.php');
exit;
}
?>
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Login</title>
</head>
<body>
<form method="POST" action="Main.php">
<?php
if (isset($_SESSION['error']))
{
echo $_SESSION['error'];
unset($_SESSION['error']);
}
?>
<p>E-mail</p>
<input type="email" placeholder="Enter e-mail" name="email" required autofocus><br><br>
<p>Password</p>
<input type="password" placeholder="Enter password" name="password" required><br><br>
<input type="submit" value="Login">
</form>
</body>
</html>
Dashboard.php
<?php
session_start();
session_regenerate_id(true);
$username = $_SESSION['username'];
if (isset($username))
{
echo "Logged in!";
echo "<br><br>";
echo "Welcome, " . htmlentities($username);
}
else
{
header('Location: signin.php');
exit;
}
Main.php
<?php
declare(strict_types = 1);
require_once __DIR__ . '/vendor/autoload.php';
session_start();
try
{
$username = 'root';
$password = '';
$conn = new \PDO("mysql:host=localhost;dbname=customers;charset=utf8mb4", $username, $password, [
\PDO::ATTR_ERRMODE => \PDO::ERRMODE_EXCEPTION,
\PDO::ATTR_EMULATE_PREPARES => false
]);
}
catch (\PDOException $e)
{
throw new \PDOException($e->getMessage(), (int) $e->getCode());
}
$user = new \Login\UserAccount();
$user->setEmail(filter_input(INPUT_POST, 'email', FILTER_SANITIZE_EMAIL));
$user->setPassword(filter_input(INPUT_POST, 'password', FILTER_SANITIZE_STRING));
(new \Login\Login($conn))->login($user);
SQL
-- phpMyAdmin SQL Dump
-- version 5.1.1
-- https://www.phpmyadmin.net/
--
-- Host: 127.0.0.1
-- Generation Time: Nov 11, 2021 at 07:49 PM
-- Server version: 10.4.21-MariaDB
-- PHP Version: 8.0.12
SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
START TRANSACTION;
SET time_zone = "+00:00";
/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
/*!40101 SET NAMES utf8mb4 */;
--
-- Database: `customers`
--
-- --------------------------------------------------------
--
-- Table structure for table `users`
--
CREATE TABLE `users` (
`id` int(11) NOT NULL,
`username` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
`passwordHash` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
`email` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
--
-- Dumping data for table `users`
--
INSERT INTO `users` (`id`, `username`, `passwordHash`, `email`) VALUES
(1, 'PHP', '$2y$10$sJgO/trlE5Ik1PuIEgzKkuur2V3vpNJ1kQAZfkyjURQD2AWuF3IWK', '[email protected]'),
(3, 'Warlock', '$2y$10$B3VHrEmkjUUk2yncfQs.V.lR8FXat0tBj.LhxWEU9U5fuXhkYcSAi', '[email protected]');
--
-- Indexes for dumped tables
--
--
-- Indexes for table `users`
--
ALTER TABLE `users`
ADD PRIMARY KEY (`id`),
ADD UNIQUE KEY `username` (`username`),
ADD UNIQUE KEY `email` (`email`);
--
-- AUTO_INCREMENT for dumped tables
--
--
-- AUTO_INCREMENT for table `users`
--
ALTER TABLE `users`
MODIFY `id` int(11) NOT NULL AUTO_INCREMENT, AUTO_INCREMENT=4;
COMMIT;
/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
If you want to make login:
E-mail: [email protected]
Pass: Rptw36VWBU%7DF
composer.json
{
"autoload":
{
"psr-4":
{
"Login\\" : "src/"
}
}
}
Questions
- Is my code clean?
- Am I following the sole responsibility principle that a class should only do one thing?
- Regarding naming, do you think I'm naming things correctly?
- What do you suggest for me to become a better developer?
I appreciate any help, if you can give tips on how to improve the code or how to learn more, something like recommending books, I would be happy to. My goal is to learn, I believe the code is well structured and easy to read, but maybe you have more experience and can find something wrong, however, my goal is to learn, so feel free to criticize and give tips.
Main.phpfile. Obs: I'm using PHP version 8.0.12 \$\endgroup\$