how many alternative ways are there, and how much better are they to transform this array?

Question

These arrays are the result of Store Procedure. They are to build a Google Chart, therefore I need transform the array to a specific format. I also want to remove the $col and $row elements that have a Null value. These arrays are dynamic to their length variable, but a $row element array always has the same length as a $cols array. I achieve that by using eval() to build the if statement dynamically.

Is there a better way to do this without using eval()? Are there any improvements that can be done?

I'm using PHP 5.4.

$cols = Array
    (
    0 => 'Name',
    1 => 'MCR',
    2 => 'MCD',
    3 => 'COM',
    4 => 'INV',
    5 => 'IDM',
    6 => 'PPO',
    7 => 'HKD',
    8 => 'ALL',
    9 => 'POS',
    10 => 'MCD-SP',
    11 => 'MCD-BH',
    12 => 'MCD-CL',
    13 => 'MCD-CO',
    14 => 'MCR-SP',
    15 => 'MCR-PO'
);

$rows = Array(
    0 => Array(
        0 => 'Primero',
        1 => 19683.43,
        2 => NULL,
        3 => 3757.38,
        4 => NULL,
        5 => NULL,
        6 => NULL,
        7 => NULL,
        8 => NULL,
        9 => NULL,
        10 => NULL,
        11 => NULL,
        12 => NULL,
        13 => NULL,
        14 => NULL,
        15 => NULL
    ),
    1 => Array
        (
        0 => 'Segundo',
        1 => 15340.5767,
        2 => NULL,
        3 => NULL,
        4 => NULL,
        5 => NULL,
        6 => NULL,
        7 => NULL,
        8 => NULL,
        9 => NULL,
        10 => NULL,
        11 => NULL,
        12 => NULL,
        13 => NULL,
        14 => NULL,
        15 => NULL
    ),
    2 => Array
        (
        0 => 'Tercero',
        1 => NULL,
        2 => NULL,
        3 => NULL,
        4 => NULL,
        5 => NULL,
        6 => NULL,
        7 => NULL,
        8 => NULL,
        9 => NULL,
        10 => 4969.65,
        11 => NULL,
        12 => NULL,
        13 => NULL,
        14 => 23695.39,
        15 => NULL
    ),
    3 => Array
        (
        0 => 'Cuarto',
        1 => NULL,
        2 => NULL,
        3 => NULL,
        4 => NULL,
        5 => NULL,
        6 => NULL,
        7 => NULL,
        8 => NULL,
        9 => NULL,
        10 => NULL,
        11 => 45974.86,
        12 => NULL,
        13 => NULL,
        14 => NULL,
        15 => NULL
    ),
    4 => Array
        (
        0 => 'Quinto',
        1 => NULL,
        2 => NULL,
        3 => NULL,
        4 => NULL,
        5 => NULL,
        6 => NULL,
        7 => NULL,
        8 => NULL,
        9 => NULL,
        10 => 1405.8,
        11 => 39244,
        12 => NULL,
        13 => NULL,
        14 => NULL,
        15 => NULL
    )
);

$qty_col = count($cols) - 1;
$qty_rows = count($rows);
//echo $qty_rows;

$ifScript = '';
for ($a = 1; $a <= $qty_col; $a++) {
    $unsetScript = 'unset(';
    $ifScript .='if(';
    for ($b = 0; $b <= $qty_rows; $b++) {
        $ifScript .= 'empty($rows[' . $b . '][' . $a . '])';
        $unsetScript .='$rows[' . $b . '][' . $a . ']';
        if ($b == $qty_rows) {
            $ifScript .='){';
            //$ifScript .='){<br>';
            $unsetScript .=', $cols[' . $a . ']);';
        } else {
            $ifScript .= ' && ';
            $unsetScript .=', ';
        }
    }
    $ifScript .= $unsetScript . '}';
    //$ifScript .= $unsetScript . '<br>}<br>';
}


//echo $ifScript;
eval($ifScript);
$cols = array_values($cols);
$rows = array_map('array_values', $rows);

foreach ($cols as $key => $value) {
    $cols[$key] = array(
        'id' => NULL,
        'label' => $value
    );
    $type = ($key == 0) ? 'string' : 'number';
    $cols[$key]['type'] = $type;
}

foreach ($rows as $key1 => $value1) {
    foreach ($value1 as $key2 => $value2) {
        $val = (empty($value2)) ? '0.00' : $value2;
        $format = ($key2 == 0) ? strtoupper(trim($value2)) : '$' . number_format($value2, '2', '.', ',');
        $value1[$key2] = array(
            'v' => $val,
            'f' => $format
        );
    }
    $rows[$key1] = array(
        'c' => $value1
    );
}
$newArray = array(
    'cols' => $cols,
    'rows' => $rows
);
echo '<pre>';
print_r($newArray);
echo '</pre>';

Output

Iterator garden by hakre. But please just search the web. That's how I came across it as well :) — kaiser, Commented Jan 8, 2014 at 1:42
If you're using eval that much, the question isn't "is there a better way", but "how many alternative ways are there, and how much better are they" ;-P — Elias Van Ootegem, Commented Jan 8, 2014 at 7:13
I just erased two attempts at making this better as I didn't like my own results. When you do get this solved, please post the improved code. — dotancohen, Commented Jan 8, 2014 at 13:29
@dotancohen could you please share your idea in ideone.com two heads are better than one — Emilio Gort, Commented Jan 8, 2014 at 15:11

roosevelt · Accepted Answer · 2014-01-09 22:25:12Z

Why not do something like this?

$output = array();

if((bool)$cols && (bool)$rows) {
    foreach($rows as $row_index => $row) {
        foreach($cols as $column_index => $column_name) {
            $column_has_atleast_one_value = false;
            if(isset($row[$column_index]) && (bool)$row[$column_index]){
                $output["cols"][$column_index] = array(
                    "id" => NULL,
                    "label" => $column_name,
                    "type" => ($column_index == 0) ? 'string' : 'number'
                );
            }
        }
    }
}

if((bool)$rows) {

    foreach($rows as $row_index => $columns) {
        foreach($columns as $column_index => $column_data){
            if(!isset($output["cols"][$column_index])){
                continue;
            }
            $column_formatted = "";
            if($column_index == 0) {
                $column_formatted = strtoupper($column_data);
            } else {
                if(!(bool)$column_data) {
                    $column_data = "0.00";
                }
                $column_formatted = '$' . number_format($column_data, '2', '.', ',');
            }
            $output["rows"][$row_index]["c"][$column_index] = array(
                "v" => $column_data,
                "f" => $column_formatted
            );
        }
    }
}

echo "<pre>";
print_r($output);
echo "</pre>";

Output

thanks, but I have to remove the $col and $row elements that have a Null value... see my output it has only 6 elements for each col...that's the part I made with eval() — Emilio Gort, Commented Jan 9, 2014 at 21:28
Hi, I updated my code to get rid of the columns that have null values. When you are dealing with array or databases, try your best to keep the index keys same across all datasets. Because one misleading number can throw the whole structure off. — roosevelt, Commented Jan 9, 2014 at 22:27
Thanks, Could we have a chat?, I see new things for me in your script that I want to learn if you can clarify. the continue and the (bool)$cols. Also I reset the array because google chart doesn't work if the array isn't reset — Emilio Gort, Commented Jan 9, 2014 at 22:53

Stack Exchange Network

how many alternative ways are there, and how much better are they to transform this array?

1 Answer 1

Your Answer

Not the answer you're looking for? Browse other questions tagged
php
array
or ask your own question.

Hot Network Questions

how many alternative ways are there, and how much better are they to transform this array?

1 Answer 1

Your Answer

Sign up or log in

Post as a guest

Not the answer you're looking for? Browse other questions tagged phparray or ask your own question.

Related

Hot Network Questions

Not the answer you're looking for? Browse other questions tagged
php
array
or ask your own question.