Revisions to Address book app to learn bash

More typos

Source Link

edited Jul 8, 2015 at 18:31

mdfst13

21.7k
6
33
68

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in sab-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-else statement in sab-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in sab-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

More typos

Source Link

edit approved Jul 8, 2015 at 18:31

jacwah

2.7k
17
42

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in `add-removesab-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in `add-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-else statement in sab-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

More typos

Source Link

edited Jul 8, 2015 at 18:14

Marc-Andre

6.7k
5
38
65

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use a named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in `add-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use a named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in `add-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.

./sab-find-db assumes that sab-find-db exists in your working directory. Why should it?
In the usage-output you should display the program name without path , so die "usage: $(basename $0) ....
Maybe it is more useful if you use different error codes and not only '1'.
A short comment at the beginning of the file about its purpose is useful.
sab-remove does not contain a usage message.
Most users assume that the option '-?' produces a usage message.
It is a good idea to use named variables in the code and not positional parameters. At the top of the function you assign the positional parameters to the named variables. If you change your parameter order or insert/delete new positional parameters you only have to change the first lines of your code.
mvas in mv "$file" target in sab-remove is not a good idea. "$file" replaces target, but not only the content is replaced but also the ownership and the permissions. Do cp "$file" target instead of mv.
I do not understand the second if-then-else statement in `add-remove. Does this mean you do not want to remove the last entry in the file?
sab-find-db is a name that irritates me. I would prefer something like sab-dbpath.