Timeline for Order a delicious pie here
Current License: CC BY-SA 3.0
16 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 23, 2017 at 12:41 | history | edited | CommunityBot |
replaced http://stackoverflow.com/ with https://stackoverflow.com/
|
|
| Apr 13, 2017 at 12:40 | history | edited | CommunityBot |
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
|
|
| Jun 9, 2015 at 19:46 | vote | accept | Alex L | ||
| Jan 29, 2015 at 14:58 | comment | added | Tim Vermaelen |
Ah yes, some bugs could still be in there. Nothing too fancy but small mistakes by my interpretation. Easy things to cover with debug tools. Concerning the hasOwnProperty: the getData method covers these. It then becomes a question whether you can trust the data or not. In some occasions it could be handy to render incomplete data to spot "data issues". If trust is an issue, always use hasOwnProperty. I kinda left that open in setFlavors.
|
|
| Jan 28, 2015 at 0:56 | history | bounty ended | Alex L | ||
| Jan 26, 2015 at 3:44 | comment | added | David Harkness |
Great job and very clean. There are two bugs in setFlavors: you mix this as the jQuery flavors selector elements and the OrderPie module, and you're missing a call to hasOwnProperty (unless there are cases you recommend omitting it).
|
|
| Jan 23, 2015 at 16:55 | history | edited | Tim Vermaelen | CC BY-SA 3.0 |
added 9 characters in body
|
| Jan 23, 2015 at 14:14 | history | edited | Tim Vermaelen | CC BY-SA 3.0 |
added 5 characters in body
|
| Jan 23, 2015 at 14:03 | comment | added | Tim Vermaelen | Thanks for that template chooser link, didn't know about that one. Although you might have noticed certain option combinations yield no results. I've updated my answer to your questions. | |
| Jan 23, 2015 at 13:35 | history | edited | Tim Vermaelen | CC BY-SA 3.0 |
added 644 characters in body
|
| Jan 23, 2015 at 12:39 | history | edited | Tim Vermaelen | CC BY-SA 3.0 |
added 644 characters in body
|
| Jan 23, 2015 at 5:24 | comment | added | Alex L | Wow! I really like what you've done here. Talk about refactoring! I appreciate the time you must have put into this, and it's easy to read and interpret. I'll have to work with it and see what I can do. I do have a couple questions though, 1) imagine this app gets bigger, much bigger, even if I separated the different parts into other files, how well would this scale? 2) what's your opinion on using a more versatile templating library? | |
| Jan 22, 2015 at 19:15 | comment | added | Tim Vermaelen | Yes, that would indeed be an even better approach. | |
| Jan 22, 2015 at 17:34 | comment | added | Flambino | Nice - I'd take a step further, though, and add the templates as hidden elements in the markup. Say make a "template" class that hides those element and makes them easy to find. That'll keep the markup in one place, so you don't have to write HTML in you JS | |
| Jan 22, 2015 at 17:26 | history | edited | Tim Vermaelen | CC BY-SA 3.0 |
deleted 2 characters in body
|
| Jan 22, 2015 at 17:16 | history | answered | Tim Vermaelen | CC BY-SA 3.0 |