Timeline for Android "Search" Activity and corresponding XML
Current License: CC BY-SA 3.0
12 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 27, 2014 at 21:08 | comment | added | user3968848 | Thanks a lot! I will post the databasehelper class soon! | |
| Aug 27, 2014 at 21:07 | comment | added | Jeroen Vannevel |
Public methods typically get javadoc, yes. Non-public ones do too sometimes, but not always since that is not part of the public API. They often just stick to a casual comment (//). Note that I added a little remark at the end: you should restrict the visibility more.
|
|
| Aug 27, 2014 at 21:05 | history | edited | Jeroen Vannevel | CC BY-SA 3.0 |
added 193 characters in body
|
| Aug 27, 2014 at 21:03 | comment | added | Jeroen Vannevel | The code is generally fine but it's a little too few to accurately gauge the quality. Don't hesitate to submit that 1K LOC databasehelper for a review, we've dealt with bigger ones and it sounds like that might be an interesting one for a review. I typically initialize them in the constructor, yes. Unless you have a very specific usecase where you actually need them in a separate method, you should just stuff it in the constructor (although it might make it clearer when there are other kinds of initializing going on in the constructor). | |
| Aug 27, 2014 at 21:02 | comment | added | user3968848 | Note: I have a javadoc comment on every method as I was told, in college, it was good practice? Perhaps this is not true | |
| Aug 27, 2014 at 21:00 | comment | added | user3968848 | Also, should I initialise all my vars in the constructor? | |
| Aug 27, 2014 at 20:59 | comment | added | user3968848 | It does surely,generally would you say that the code is of a decent standard? thanks | |
| Aug 27, 2014 at 20:58 | vote | accept | user3968848 | ||
| Aug 27, 2014 at 20:56 | comment | added | Jeroen Vannevel | @user3968848: I elaborated on it, does that answer any doubts left? | |
| Aug 27, 2014 at 20:56 | history | edited | Jeroen Vannevel | CC BY-SA 3.0 |
added 1124 characters in body
|
| Aug 27, 2014 at 20:49 | comment | added | user3968848 | Thank you that is great feedback! Could you possibly give me a bit more detail/example on the commenting? | |
| Aug 27, 2014 at 20:46 | history | answered | Jeroen Vannevel | CC BY-SA 3.0 |