Timeline for PHP isset over use? Good or bad?
Current License: CC BY-SA 3.0
19 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 2, 2014 at 13:50 | answer | added | dmgig | timeline score: 1 | |
| Jun 19, 2014 at 8:27 | comment | added | Josef Engelfrost | I think @JohnPoison did a pretty good job. Don't overlook what he writes at the very end: "it's good to have separate controller to handle all request params and a separate view to render". | |
| Jun 19, 2014 at 0:55 | history | edited | RubberDuck |
edited tags
|
|
| Jun 19, 2014 at 0:11 | history | edited | Richard | CC BY-SA 3.0 |
added more info and completed code
|
| Jun 19, 2014 at 0:03 | history | edited | Richard | CC BY-SA 3.0 |
added 760 characters in body
|
| Jun 18, 2014 at 23:57 | comment | added | Richard | @JosefOttosson: if you have time to review the whole code please do. I have added the whole code. | |
| Jun 18, 2014 at 18:04 | history | edited | Jamal | CC BY-SA 3.0 |
added 989 characters in body
|
| Jun 18, 2014 at 13:23 | answer | added | Ivan Fateev | timeline score: 8 | |
| Jun 18, 2014 at 13:01 | comment | added | Josef Engelfrost |
By the way, your code is missing an ending brace somewhere, and safeVal() and $pgeBreadcumbs are not set.
|
|
| Jun 18, 2014 at 12:57 | comment | added | Josef Engelfrost |
All isset($var) does is check if $var is set and is not null. You are using it correctly. Do you want a review of the code as a whole, or are you mainly concerned about isset()?
|
|
| Jun 18, 2014 at 12:05 | history | edited | 200_success |
edited tags
|
|
| Jun 18, 2014 at 11:15 | comment | added | Richard | @JosefOttosson : I'm not aware of any other way to catch $_POST variable other than islet, well i know that i can use extract($_POST) but ppl said that isn't a safe way to do it. | |
| S Jun 18, 2014 at 10:54 | history | edited | RubberDuck | CC BY-SA 3.0 |
The question does not concern mysqli, the code just happens to use it.
|
| S Jun 18, 2014 at 10:54 | history | suggested | Josef Engelfrost |
The question does not concern mysqli, the code just happens to use it.
|
|
| Jun 18, 2014 at 10:51 | review | Suggested edits | |||
| S Jun 18, 2014 at 10:54 | |||||
| Jun 18, 2014 at 10:42 | comment | added | Josef Engelfrost | If you want to dig into performance start with Big O notation. You're current code is doing very well. | |
| Jun 18, 2014 at 10:38 | comment | added | Josef Engelfrost | If you're having performance issues, isset() is not the problem. Focus on writing readable and maintainable code, if you (and others) find isset() readable, use isset(). | |
| Jun 18, 2014 at 10:00 | review | First posts | |||
| Jun 18, 2014 at 10:21 | |||||
| Jun 18, 2014 at 9:42 | history | asked | Richard | CC BY-SA 3.0 |