Timeline for Factory Method implementation
Current License: CC BY-SA 3.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Apr 28, 2014 at 15:27 | comment | added | Mathieu Guindon | Good point. Don't forget that bad naming can be part of a fruitful peer review - feel free to join us in The 2nd Monitor/Code Review Chat ;) | |
| Apr 28, 2014 at 15:11 | comment | added | Stuart Blackler | @Mat'sMug I agree, that's what I would normally do. I try and steer clear of changing variable names in reviews and stick with what the OP has as it will correlate better for them, imo. :) | |
| Apr 28, 2014 at 13:41 | comment | added | Mathieu Guindon |
+1 excellent point. I'd call the enum type TreeType though (singular), and find another name for the abstract factory interface.
|
|
| Apr 28, 2014 at 6:41 | vote | accept | Thava | ||
| Apr 28, 2014 at 4:21 | comment | added | Thava | Hi @Stuart Blackler, thanks for your reply. my doubt is instead of abstract class I’ve used faza class. is it creates any issue? ,, regd. enum i agree with your point. | |
| Apr 27, 2014 at 11:24 | history | edited | Stuart Blackler | CC BY-SA 3.0 |
Fixed formatting
|
| Apr 27, 2014 at 11:18 | history | answered | Stuart Blackler | CC BY-SA 3.0 |