Skip to main content
added 7 characters in body
Source Link
Jamal
  • 34.9k
  • 13
  • 133
  • 237
  1. player_score>=computer_score makes the computer win even when they score the same. A comparison should be > instead of `>='>= (same for the next clause).

  2. The game, as coded, may terminate early (before reaching 5 rounds). For me, it contradictcontradicts the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.

  1. player_score>=computer_score makes computer win even when they score the same. A comparison should be > instead of `>=' (same for the next clause).

  2. The game as coded may terminate early (before reaching 5 rounds). For me, it contradict the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.

  1. player_score>=computer_score makes the computer win even when they score the same. A comparison should be > instead of >= (same for the next clause).

  2. The game, as coded, may terminate early (before reaching 5 rounds). For me, it contradicts the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.

edited body
Source Link
vnp
  • 57.3k
  • 4
  • 51
  • 140
  1. player_score>=computer_score makes computer win even when they score the same. A comparison should be > instead of `>=' (same for the next clause).

  2. The game as coded may terminate early (before reaching 5 rounds). For me, it contradict the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.

  1. player_score>=computer_score makes computer win even when they score the same. A comparison should be > instead of `>=' (same for the next clause).

  2. The game as coded may terminate early (before reaching 5 rounds). For me, it contradict the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.

  1. player_score>=computer_score makes computer win even when they score the same. A comparison should be > instead of `>=' (same for the next clause).

  2. The game as coded may terminate early (before reaching 5 rounds). For me, it contradict the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.

Source Link
vnp
  • 57.3k
  • 4
  • 51
  • 140

  1. player_score>=computer_score makes computer win even when they score the same. A comparison should be > instead of `>=' (same for the next clause).

  2. The game as coded may terminate early (before reaching 5 rounds). For me, it contradict the requirements.

  3. User input shall be validated (is it really a number?) somehow.

  4. I don't know if you covered functions already. If so, factor out all the copy-pastes into functions.