Revisions to Vertically placing the words in a string

Added the else part of output printing 'if' condition : This now prints properly.

Source Link

edit approved Apr 9, 2014 at 8:32

269
1
2
9

Looking at this code:

if(strTemp.length() > maxWordLen)
    maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
            else {
                //two spaces, added by xploreraj in Edit
                //in case a shorter word comes before longer word
                //we must compensate the absence of character with space
                System.out.print("  ");
            }
        }
        System.out.println();
        i++;
    }

Looking at this code:

if(strTemp.length() > maxWordLen)
    maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
        }
        System.out.println();
        i++;
    }

Looking at this code:

if(strTemp.length() > maxWordLen)
    maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
            else {
                //two spaces, added by xploreraj in Edit
                //in case a shorter word comes before longer word
                //we must compensate the absence of character with space
                System.out.print("  ");
            }
        }
        System.out.println();
        i++;
    }

edited body

Source Link

edited Apr 8, 2014 at 16:13

Jamal

34.9k
13
133
237

Looking at this code:

if(strTemp.length() > maxWordLen)
         maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
        }
        System.out.println();
        i++;
    }

Looking at this code:

if(strTemp.length() > maxWordLen)
         maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
        }
    System.out.println();
    i++;
}

Looking at this code:

if(strTemp.length() > maxWordLen)
    maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
        }
        System.out.println();
        i++;
    }

added 414 characters in body

Source Link

edited Apr 8, 2014 at 12:30

PKopachevsky

400
2
5

Looking at this code:

if(strTemp.length() > maxWordLen)
         maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
        }
    System.out.println();
    i++;
}

Looking at this code:

if(strTemp.length() > maxWordLen)
         maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

Looking at this code:

if(strTemp.length() > maxWordLen)
         maxWordLen = strTemp.length();

This could be reduced to:

maxWordLen = Math.max(maxWordLen,strTemp.length());

Inline the incrementation:
```
charArr[i][j++] = ch;
```

Or just use System.arraycopy:

    char[][] charArr = new char[strArr.length][maxWordLen];
    for (int i = 0; i < strArr.length; i++) {
        System.arraycopy(strArr[i].toCharArray(), 0, charArr[i], 0, strArr[i].length());
    }

Either inline the output:

System.out.print((i != 0 ? " " : "") + charArr[i][j]);

or at least place braces:

if (i!=0){
   System.out.print(" ");
}

4 . If you wonder about other solutions, check this one:

    int i = 0;

    boolean hasMoreChars = true;

    while (hasMoreChars) {

        hasMoreChars = false;

        for (String str : strArr) {

            if (i < str.length()) {

                hasMoreChars = true;

                System.out.print(str.charAt(i) + " ");
            }
        }
    System.out.println();
    i++;
}

reformatted code to code. these lists are f*cking everything up

Source Link

edited Apr 8, 2014 at 10:41

Vogel612

25.3k
7
58
141

Loading

added 228 characters in body

Source Link

edited Apr 8, 2014 at 10:03

PKopachevsky

400
2
5

Loading

Source Link

created Apr 8, 2014 at 9:58

PKopachevsky

400
2
5

Loading

Stack Exchange Network

Return to Answer