Timeline for Rock, Paper, Scissors in Python
Current License: CC BY-SA 3.0
10 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Apr 7, 2014 at 6:44 | comment | added | DBedrenko | @msh210 It's more concise and just as readable, if not more readable. | |
| Apr 7, 2014 at 1:26 | comment | added | tda | Should I use my own program with modifications, or is Rusian Osipov's edit better? | |
| Apr 6, 2014 at 22:27 | comment | added | tda | I pulled the update and will add this. Thank you for your help. | |
| Apr 6, 2014 at 22:11 | comment | added | amon | @TjF your code has two concerns: deciding who won, and printing out the result. Combining these two is inelegant, it is better to put each concern into a seperate function. So my above answer suggested one function to find out which move one (and will return a verb describing how the move won), plus one function to format the message. The main input loop doesn't have to do anything besides printing out the actual result. This will make it easier to extend your program later. | |
| Apr 6, 2014 at 22:06 | comment | added | tda | I was sort of confused by this. Wondering if you could help me a little further on that? | |
| Apr 6, 2014 at 22:05 | comment | added | amon | @TjF As far as I can see, you only improved variable names. That is good, but I mentioned many more issues like indentation and helper functions. Any review on your updated code will mention those as well, which is unnecessary. Consider doing more substantial improvements. | |
| Apr 6, 2014 at 21:59 | comment | added | tda | here is my updated program | |
| Apr 6, 2014 at 21:35 | comment | added | tda | Will fix up the code and come back for second round of review. | |
| Apr 6, 2014 at 21:34 | vote | accept | tda | ||
| Apr 6, 2014 at 20:57 | history | answered | amon | CC BY-SA 3.0 |