Skip to main content
Code Review

Return to Answer

edited body
Source Link
Heslacher
Heslacher
  • 50.4k
  • 5
  • 81
  • 175

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this. Isn't the exception message contradicting the if clause?

if (value < CLEARED)
    throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

CLEARED is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString() have four parameters on String.Format, only using three?

I'll have a closer look thenwhen I'm at a computer, but nice work!

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this. Isn't the exception message contradicting the if clause?

if (value < CLEARED)
    throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

CLEARED is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString() have four parameters on String.Format, only using three?

I'll have a closer look then I'm at a computer, but nice work!

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this. Isn't the exception message contradicting the if clause?

if (value < CLEARED)
    throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

CLEARED is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString() have four parameters on String.Format, only using three?

I'll have a closer look when I'm at a computer, but nice work!

deleted 7 characters in body
Source Link
Jamal
Jamal
  • 34.9k
  • 13
  • 133
  • 237

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this, isn't. Isn't the exception message contradicting the ifif clause?

        if (value < CLEARED)
            throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

ClearedCLEARED is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString()toString() have four parameters on String.FormatString.Format, only using three?

I'll have a closer look then I'm at a computer, but nice work!

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this, isn't the exception message contradicting the if clause?

        if (value < CLEARED)
            throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

Cleared is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString() have four parameters on String.Format, only using three?

I'll have a closer look then I'm at a computer, but nice work!

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this. Isn't the exception message contradicting the if clause?

if (value < CLEARED)
    throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

CLEARED is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString() have four parameters on String.Format, only using three?

I'll have a closer look then I'm at a computer, but nice work!

Source Link
Niclas Lindqvist
Niclas Lindqvist
  • 351
  • 2
  • 5

Can't read all this code on my phone even though it looks pretty well structured to me! Good job!

I saw this, isn't the exception message contradicting the if clause?

        if (value < CLEARED)
            throw new ArgumentOutOfRangeException("SudokuTile Value cannot be zero or smaller. Was " + value);

Cleared is set to 0, and the if checks for 'less than 0' so the value could be set to 0.

Also, not having run the code, why does the toString() have four parameters on String.Format, only using three?

I'll have a closer look then I'm at a computer, but nice work!