Timeline for Weekend Challenge - Poker Hand Evaluation
Current License: CC BY-SA 3.0
14 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 5, 2017 at 15:26 | answer | added | Simon Forsberg | timeline score: 11 | |
| Apr 13, 2017 at 12:40 | history | edited | CommunityBot |
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
|
|
| Mar 16, 2017 at 16:38 | history | edited | CommunityBot |
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
|
|
| Oct 4, 2014 at 2:53 | comment | added | Jon | @Jamel Your PokerHandType enum is lacking five of a kind. You are using a joker, five of a kind is the best hand in poker, beats a royal. You also use Royal_Flush In the enum, but a Royal is simply a straight flush, just the highest straight flush so it has code smell that you might be doing something with a royal flush, that you could adequately do treating it as a straight flush. | |
| Dec 22, 2013 at 22:47 | history | edited | Jamal |
edited tags
|
|
| Dec 15, 2013 at 23:15 | vote | accept | Simon Forsberg | ||
| Dec 14, 2013 at 2:31 | comment | added | Adam | Nitpicking: the term is suit, not suite. | |
| Dec 9, 2013 at 19:08 | comment | added | Simon Forsberg |
@abuzittingillifirca Interesting suggestion. I have put the classes inside a package, net.zomis.cards.poker.validation, but when pressing Ctrl + Shift + T in Eclipse I often forget the classnames, and I find it much easier to write Poker to find my classes. This is not something I always do for all other projects though...
|
|
| Dec 9, 2013 at 18:51 | comment | added | abuzittin gillifirca |
Do not use prefixes in stead of a package name. That is put class PokerXyz to package poker and use Xyz only.
|
|
| Dec 9, 2013 at 2:41 | answer | added | rolfl | timeline score: 25 | |
| Dec 8, 2013 at 20:35 | comment | added | Simon Forsberg | @retailcoder Flexible code, correct code (coughs), short code - Can't have it all. | |
| Dec 8, 2013 at 20:33 | comment | added | Simon Forsberg | @retailcoder tag:status-bydesign. I only consider a complete "Poker Hand" to be five cards. If you have seven cards, then only five of those will be included in a poker hand. Therefore, if you have a straight (five cards), you don't have a kicker. (I'm thinking Texas Hold 'em here, there might be other variations) | |
| Dec 8, 2013 at 20:31 | comment | added | Mathieu Guindon | And is it me or no "kicker" for a straight is assuming you're playing 5-cards (the rest of your code isn't...)? You couldn't tell the winner of a 7-card deal where the two players had the same straight, even if one's 6th card was an Ace of Hearts and the other player's 6th card was a 2 of clubs. Right or wrong? :p | |
| Dec 8, 2013 at 17:45 | history | asked | Simon Forsberg | CC BY-SA 3.0 |