Skip to main content
deleted 1 characters in body
Source Link
Jeff Vanzella
  • 4.3k
  • 2
  • 23
  • 33

First thing I noticed, I do not like the Do in the function names. For instance, in DoArchiveOldInstallers there are two verbs. The idea is to mimic english, I never say "Do go for a run" when I'm talking to people. The code should be the same. ArchiveOldInstallers works perfectly well, and the verb describing what is going on is still there.

Second, the if statements get a little confustionconfusing. I'm not sure what to do with them right now, but they need to be changed.

Other than that, the white space, capitalization, and formatting look good.

First thing I noticed, I do not like the Do in the function names. For instance, in DoArchiveOldInstallers there are two verbs. The idea is to mimic english, I never say "Do go for a run" when I'm talking to people. The code should be the same. ArchiveOldInstallers works perfectly well, and the verb describing what is going on is still there.

Second, the if statements get a little confustion. I'm not sure what to do with them right now, but they need to be changed.

Other than that, the white space, capitalization, and formatting look good.

First thing I noticed, I do not like the Do in the function names. For instance, in DoArchiveOldInstallers there are two verbs. The idea is to mimic english, I never say "Do go for a run" when I'm talking to people. The code should be the same. ArchiveOldInstallers works perfectly well, and the verb describing what is going on is still there.

Second, the if statements get a little confusing. I'm not sure what to do with them right now, but they need to be changed.

Other than that, the white space, capitalization, and formatting look good.

Source Link
Jeff Vanzella
  • 4.3k
  • 2
  • 23
  • 33

First thing I noticed, I do not like the Do in the function names. For instance, in DoArchiveOldInstallers there are two verbs. The idea is to mimic english, I never say "Do go for a run" when I'm talking to people. The code should be the same. ArchiveOldInstallers works perfectly well, and the verb describing what is going on is still there.

Second, the if statements get a little confustion. I'm not sure what to do with them right now, but they need to be changed.

Other than that, the white space, capitalization, and formatting look good.