Timeline for Wrap a noexcept C++ library method with a method throwing exceptions with usable explanatory strings to stay DRY
Current License: CC BY-SA 4.0
6 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Jan 15 at 7:26 | vote | accept | ridilculous | ||
Jan 11 at 21:13 | history | edited | G. Sliepen | CC BY-SA 4.0 |
added 219 characters in body
|
Jan 10 at 20:25 | comment | added | G. Sliepen | Nice, but if you want to have it reviewed, make a new question here on Code Review :) | |
Jan 10 at 18:20 | comment | added | ridilculous |
I like a lot of things here. I found two points which i tried to further improve. What do you think about these changes? what returns an optional now to avoid having to return an empty string and further delegate the ok condition. It also takes the actual function as a second argument so that the messages can be based on the concrete function to cover "What if you want to wrap another function that also returns a CreateDirectoryResult " for cases where (maybe just slightly) different messages would make more sense.
|
|
Jan 10 at 15:22 | history | edited | G. Sliepen | CC BY-SA 4.0 |
added 204 characters in body
|
Jan 10 at 15:14 | history | answered | G. Sliepen | CC BY-SA 4.0 |