Timeline for 32x32x32 Units Octree With 15-Bit Voxels: Second Edition
Current License: CC BY-SA 4.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| S Sep 21, 2023 at 6:21 | history | suggested | CPlus | CC BY-SA 4.0 |
Fixed the logic in the refactored version, as the octree_get() function should not modify the tree; NOTE: I am the OP of the question
|
| Sep 20, 2023 at 21:38 | review | Suggested edits | |||
| S Sep 21, 2023 at 6:21 | |||||
| Sep 20, 2023 at 17:14 | comment | added | G. Sliepen |
That has helped a bit, but on the other hand, octree_set() is now much larger than Set() was in your previous version. Also, there still is very little whitespace, you still have assignments inside function calls, and there still are some variables that have a very short name (like u in Ptr).
|
|
| Sep 20, 2023 at 13:34 | comment | added | CPlus | Even though I have made helper functions and given vars more meaningful names? | |
| Sep 20, 2023 at 6:57 | comment | added | G. Sliepen | Sorry, but I didn't notice any improvement in readability. | |
| Sep 19, 2023 at 15:24 | comment | added | CPlus | Yes Make your code more readable was included in both the old and the new. But can we at least agree that there was some improvement, even if the code is still not as readable as it should be? | |
| Sep 17, 2023 at 16:51 | comment | added | CPlus |
Note: the only way for if (octree->set_alloc != alloc) to be be true and thus execute (and thus use the alloc_size variable) is is if the body of the above while loop executes at least once, meaning the condition would execute at least twice. If the condition only executes once, then alloc will be equal to octree->set_alloc because it was just assigned to it.
|
|
| Sep 17, 2023 at 15:24 | history | answered | G. Sliepen | CC BY-SA 4.0 |