Timeline for Intersecting rectangles on a torus
Current License: CC BY-SA 4.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 2, 2023 at 5:26 | comment | added | FreddyFlares | @J_H I wish C# had macros, it does however have attributes for inlining small methods which is what I use. I also have functions called WrapToWidth and WrapToHeight that I use all over my own code. I forgot to include them here sorry. Comments taken onboard. | |
| S Feb 2, 2023 at 5:06 | review | First answers | |||
| Feb 2, 2023 at 7:44 | |||||
| S Feb 2, 2023 at 5:06 | history | edited | FreddyFlares | CC BY-SA 4.0 |
added 74 characters in body
|
| Feb 2, 2023 at 2:17 | comment | added | J_H |
DRY. Compute dx with a function or (gasp!) a cpp macro, then same for dy. (This codebase does not use [0] for X, [1] for Y, and that is perfectly fine, but one way to parameterize a helper would be by passing in a 0 / 1 subscript.) The double ternary operator is too long. Add (redundant) parentheses to help human readers, and maybe put each on its own line.
|
|
| Feb 2, 2023 at 0:34 | comment | added | pacmaninbw♦ | While it is definitely okay to answer your own question if you want a new review of the modified code it is better if you post a follow up question with a link back to this question. | |
| Feb 1, 2023 at 21:11 | history | edited | FreddyFlares | CC BY-SA 4.0 |
added 217 characters in body
|
| S Feb 1, 2023 at 20:41 | review | First answers | |||
| Feb 2, 2023 at 0:34 | |||||
| S Feb 1, 2023 at 20:41 | history | answered | FreddyFlares | CC BY-SA 4.0 |