Timeline for Refactoring tips
Current License: CC BY-SA 3.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 4, 2013 at 12:29 | comment | added | Kickstart | You appear to loop through a returned page, assigning every occurrence of given-name to first_name. Each time you do this you will over write the previous one, so you will only have the last one. You then insert all these last found fields into linkedin_parse, but that will only insert a single record, returning the id field. You then select everything from that table for that row id. As there is only a single record and you already have all the details in the script there seems to be no point to this select. | |
| Jul 4, 2013 at 2:09 | history | tweeted | twitter.com/#!/StackCodeReview/status/352610168359485440 | ||
| Jul 3, 2013 at 17:47 | vote | accept | Aj Villalobos | ||
| Jul 3, 2013 at 17:40 | answer | added | Jacob S | timeline score: 2 | |
| Jul 3, 2013 at 17:39 | comment | added | Jacob S | Link to on hold StackOverflow Question -- I will add my answer here for others to consider as well, in case they may wish to improve it. | |
| Jul 3, 2013 at 17:25 | review | First posts | |||
| Jul 3, 2013 at 17:28 | |||||
| Jul 3, 2013 at 17:06 | history | asked | Aj Villalobos | CC BY-SA 3.0 |