added 1 character in body

Source Link

edited Jan 12, 2022 at 21:42

6.2k
21
41

PEP8

You should use snake_case for fuctionfunction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid host addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid host addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

PEP8

You should use snake_case for function names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid host addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

added 5 characters in body

Source Link

edited Jan 12, 2022 at 12:47

Richard Neumann

6.2k
21
41

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid host addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid host addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

deleted 1 character in body

Source Link

edited Jan 12, 2022 at 9:17

Richard Neumann

6.2k
21
41

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions.

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions.

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

PEP8

You should use snake_case for fuction names. You did so with ip_information, why not with to_binary as well?

Naming

The function name ip_information does not convey what it precisely does. You might want to rename it.

Docstrings

Both of your functions are excellent candidates for docstrings to describe what they are supposed to be doing.

Use existing library functions

Since you did not tag reinventing-the-wheel, I suppose that you just want to get the job done. If so, your entire code can be replaced with the usage of the ipaddress module from the standard library:

from ipaddress import IPv4Network


def print_network_information(ipv4network: IPv4Network) -> None:
    """Prints the network address, broadcast address and number
    of addresses on the given IPv4 network.
    """

    print('Network IP:', ipv4network.network_address)
    print('Broadcast address:', ipv4network.broadcast_address)
    print('Number of hosts:', ipv4network.num_addresses)


def main() -> None:
    
    print_network_information(IPv4Network('192.168.0.0/255.255.255.0'))


if __name__ == '__main__':
    main()

Note that the number of hosts differs from your version's number, since the network address and broadcast address are also valid addresses within CIDR. If you want to compensate for this, just subtract 2 from the respective value.

added 2 characters in body

Source Link

edited Jan 12, 2022 at 8:40

Richard Neumann

6.2k
21
41

Loading

Source Link

created Jan 12, 2022 at 8:32

Richard Neumann

6.2k
21
41

Loading

Stack Exchange Network

Return to Answer

PEP8

Naming

Docstrings

Use existing library functions

PEP8

Naming

Docstrings

Use existing library functions

PEP8

Naming

Docstrings

Use existing library functions

PEP8

Naming

Docstrings

Use existing library functions

PEP8

Naming

Docstrings

Use existing library functions

PEP8

Naming

Docstrings

Use existing library functions

PEP8

Naming

Docstrings

Use existing library functions.

PEP8

Naming

Docstrings

Use existing library functions.

PEP8

Naming

Docstrings

Use existing library functions