Skip to main content
Code Review

Return to Answer

Correct grammar
Source Link
edit approved May 15, 2013 at 17:43
L. Cornelius Dol
edit approved May 15, 2013 at 17:43
L. Cornelius Dol
  • 137
  • 6

ConnectionFactory looks like a singleton and I think could probably be rewritten toand would be as safer as a singleton. Unsynchronized concurrent calls to initializeConnectionPool() would createhave unintended side effects-effects. Take a look at http://en.wikipedia.org/wiki/Singleton_pattern to see which Java singleton pattern works best for you.

ConnectionFactory looks like a singleton and I think could probably be rewritten to be as safer singleton. Unsynchronized concurrent calls to initializeConnectionPool() would create unintended side effects. Take a look at http://en.wikipedia.org/wiki/Singleton_pattern to see which Java singleton pattern works best for you.

ConnectionFactory looks like a singleton and I think could probably be rewritten and would be safer as a singleton. Unsynchronized concurrent calls to initializeConnectionPool() would have unintended side-effects. Take a look at http://en.wikipedia.org/wiki/Singleton_pattern to see which Java singleton pattern works best for you.

Source Link
will vuong
will vuong
  • 66
  • 3

ConnectionFactory looks like a singleton and I think could probably be rewritten to be as safer singleton. Unsynchronized concurrent calls to initializeConnectionPool() would create unintended side effects. Take a look at http://en.wikipedia.org/wiki/Singleton_pattern to see which Java singleton pattern works best for you.