Skip to main content
Code Review

Return to Answer

Fixed miscUtil url
Source Link
edit approved Dec 19, 2020 at 13:24
Michael Freidgeim
edit approved Dec 19, 2020 at 13:24
Michael Freidgeim
  • 103
  • 4
  1. Have you considered using Operator from MiscUtilOperator from MiscUtil instead of your Calculator?
  2. You should never use general catch. Instead, catch only the specific exception you're expecting.
  3. Since operatorName is used just for the exception, I would consider getting the name from the operator's Method.
  4. _Value probably should be exposed as a read-only property, since the cast is not very discoverable.
  1. Have you considered using Operator from MiscUtil instead of your Calculator?
  2. You should never use general catch. Instead, catch only the specific exception you're expecting.
  3. Since operatorName is used just for the exception, I would consider getting the name from the operator's Method.
  4. _Value probably should be exposed as a read-only property, since the cast is not very discoverable.
  1. Have you considered using Operator from MiscUtil instead of your Calculator?
  2. You should never use general catch. Instead, catch only the specific exception you're expecting.
  3. Since operatorName is used just for the exception, I would consider getting the name from the operator's Method.
  4. _Value probably should be exposed as a read-only property, since the cast is not very discoverable.
Source Link
svick
svick
  • 24.3k
  • 4
  • 52
  • 89

  1. Have you considered using Operator from MiscUtil instead of your Calculator?
  2. You should never use general catch. Instead, catch only the specific exception you're expecting.
  3. Since operatorName is used just for the exception, I would consider getting the name from the operator's Method.
  4. _Value probably should be exposed as a read-only property, since the cast is not very discoverable.