Timeline for Email Validation in PHP
Current License: CC BY-SA 4.0
19 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 6, 2020 at 18:00 | history | tweeted | twitter.com/StackCodeReview/status/1313539521808683008 | ||
| Oct 3, 2020 at 1:53 | comment | added | Jamal | What you may and may not do after receiving answers | |
| Oct 3, 2020 at 1:53 | history | rollback | Jamal |
Rollback to Revision 2
|
|
| Oct 1, 2020 at 23:43 | vote | accept | CommunityBot | ||
| Oct 1, 2020 at 23:34 | history | edited | user231248 | CC BY-SA 4.0 |
Improved formatting, found at the provided link under 'EDIT'
|
| Oct 1, 2020 at 21:19 | answer | added | Kate | timeline score: 4 | |
| Oct 1, 2020 at 13:15 | comment | added | slepic | @YourCommonSense Maybe I didn't say it the best way. I meant let PDO handle SQL injection and let the email adress be html escaped only where outputted into HTML which is not anywhere in the OPs provided code. | |
| Oct 1, 2020 at 10:48 | answer | added | mickmackusa | timeline score: 3 | |
| Oct 1, 2020 at 10:03 | comment | added | Your Common Sense | @slepic PDO has absolutely nothing to do with HTML and doesn't handle any. So I don't really get why did you mention it in your otherwise correct comment. | |
| Oct 1, 2020 at 9:41 | answer | added | Your Common Sense | timeline score: 5 | |
| Oct 1, 2020 at 9:26 | history | edited | Your Common Sense | CC BY-SA 4.0 |
deleted 578 characters in body
|
| Oct 1, 2020 at 4:48 | review | First posts | |||
| Oct 1, 2020 at 10:46 | |||||
| Oct 1, 2020 at 4:41 | comment | added | slepic | Oh btw i just noticed you posted two versions of this question codereview.stackexchange.com/questions/250058/… you better remove one of them or you're leaving the decision which one will be closed as duplicate to the moderators... | |
| Oct 1, 2020 at 4:35 | comment | added | slepic | Unfortunately i am short on time So ill leave that to others. Maybe just one more note, you should not show pdo exception message to the client, that belongs to a server side log. | |
| Oct 1, 2020 at 4:20 | comment | added | user231248 | @slepic I understand! Thank you, I'll make that change. Is there anything else that you'd recommend? | |
| Oct 1, 2020 at 3:48 | comment | added | slepic | You should let PDO handle it for you. No extra treatment Is necesary. Further down you do regex check anyway. And that regex basically rules out all HTML entities anyway... Use htmlspecialchars really only before outputting a value into HTML. | |
| Oct 1, 2020 at 3:41 | comment | added | user231248 | @slepic Which function should I be using? Could you elaborate in my htmlspecialchars is nonsense? | |
| Oct 1, 2020 at 3:33 | comment | added | slepic |
htmlspecialchars is nonsense. Use this function to sanitize data to be written to a HTML document. You're not doing that anywhere...
|
|
| Oct 1, 2020 at 1:07 | history | asked | user231248 | CC BY-SA 4.0 |