Timeline for Multi Threaded Error Logger
Current License: CC BY-SA 3.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 26, 2013 at 20:38 | comment | added | Jesse C. Slicer | @almaz Stephen Toub's pretty trustworthy, so kudos for posting that. | |
| Mar 26, 2013 at 20:18 | history | edited | almaz | CC BY-SA 3.0 |
Added disposition per comment
|
| Mar 26, 2013 at 20:17 | comment | added | almaz |
@JesseC.Slicer There is a nice article Do I need to dispose of Tasks? I agree that in order to be strict I should have BlockingCollection disposed.
|
|
| Mar 26, 2013 at 14:41 | comment | added | Jesse C. Slicer |
Since the Task class implements IDisposable, shouldn't _writeTask be .Dispose()'d in your Dispose() method after the .Wait()? Same goes for the _exceptions BlockingCollection object.
|
|
| Mar 26, 2013 at 13:27 | vote | accept | Justim Odendaal | ||
| Mar 26, 2013 at 5:07 | comment | added | almaz | @svick I followed the pattern of saving a log to disk in a separate thread as it was in original solution. I think having one thread dedicated to this task is a better choice then creating (out of threadpool, but still...) the thread every second. I would suggest to use the standard logging library, but it seems not an option for asker. | |
| Mar 25, 2013 at 22:57 | comment | added | svick | This probably won't matter much in a GUI application, but I think having a thread blocked most of the time is quite wasteful. And since the alternative here is not much more complicated, I fail to see why would this be a good idea. | |
| Mar 25, 2013 at 21:30 | history | answered | almaz | CC BY-SA 3.0 |