SFML implements functionalities that allow you to determine if two rectangles intersect. You can significantly shorten your current code:

const bool Game::isColliding(sf::RectangleShape player, sf::RectangleShape enemy) const 
{
    return player.getGlobalBounds().intersects(enemy.getGlobalBounds());
}

See more:

• sf::FloatRect::intersects
• sf::RectangleShape::getGlobalBounds

SFML implements functionalities that allow you to determine if two rectangles intersect. You can significantly shorten your current code:

const bool Game::isColliding(const sf::RectangleShape& player, const sf::RectangleShape& enemy) const 
{
    return player.getGlobalBounds().intersects(enemy.getGlobalBounds());
}

See more:

• sf::FloatRect::intersects
• sf::RectangleShape::getGlobalBounds