Timeline for Javacript/jQuery animation makes text appear/disappear as if typed
Current License: CC BY-SA 4.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 5, 2020 at 11:16 | history | edited | Akhil Aravind | CC BY-SA 4.0 |
added more comment and explained code
|
| Feb 5, 2020 at 10:53 | comment | added | Akhil Aravind | @Vogel612 got that. I will add a detailed explanation. :) . I am just a starter here. Thanks for the feedback. | |
| Feb 5, 2020 at 10:51 | comment | added | Vogel612 | You'll want to explain why you looped. I see that you explain what the code does, but the interesting part during a review is the why :) | |
| Feb 5, 2020 at 10:44 | comment | added | Akhil Aravind |
@Vogel612 Just replaced his setTimeOut() dump to single setTimeOut(), thats all. Its a kind of refactoring the original code. I thought I have added enough comments. Do we need to add comment for each block ??. Can you share a sample of commenting :)
|
|
| Feb 5, 2020 at 10:28 | comment | added | Vogel612 | it's kind of sad that you don't mention the superiority of looping over copy-pasting code, which is the core improvement of your code over the code presented in the question. Instead you write as if you just reimplemented this code from scratch, which would make this a bad answer (because it doesn't explain why it's better than the original code) | |
| Feb 5, 2020 at 10:26 | history | edited | Vogel612 | CC BY-SA 4.0 |
remove meta concerns
|
| Feb 5, 2020 at 10:20 | vote | accept | cobrexus | ||
| Feb 5, 2020 at 10:20 | |||||
| Feb 5, 2020 at 9:11 | history | answered | Akhil Aravind | CC BY-SA 4.0 |