Timeline for Comparing information to a directory of active enployees
Current License: CC BY-SA 4.0
12 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 23, 2019 at 17:24 | history | edited | Jamal | CC BY-SA 4.0 |
deleted 364 characters in body
|
| Dec 16, 2019 at 2:49 | history | edited | Jamal | CC BY-SA 4.0 |
edited body; edited title
|
| Nov 27, 2019 at 22:00 | answer | added | TinMan | timeline score: 1 | |
| Nov 26, 2019 at 21:55 | comment | added | Ryan Wildry |
Using SQL is great for these type of set based comparisons. You can use ADO in Excel if you wish, although it plays nicer in an actual database. I'd recommend checking that out though!
|
|
| Nov 26, 2019 at 20:29 | comment | added | AJD | Reading the previous reviews you will see many examples of using arrays to improve performance. The reason I mention all this is because while there are many people here happy to review code and provide advice, we are not a free refactoring or rewriting service. Your main question "Someone suggested loading data as variant arrays as opposed to ranges. I'm stuck." implies that you are looking for specific help, not a review. There are also many examples of using arrays instead of ranges on StackOverflow. Remember to filter searches with '[vba]' | |
| Nov 26, 2019 at 20:26 | comment | added | AJD |
Key themes to look for are Option Explicit, declaring variables on one line (hint: Dim dumpSheet, referencesheet, outputSheet As Worksheet does not do what you think it does), explicitly using default actions (e.g. Range(x).Value="" instead of Range(x) = "") and declaring variables near where you use them.
|
|
| Nov 26, 2019 at 20:22 | comment | added | AJD | My immediate suggestion is to look through previous Code Reviews for VBA and pick out some constant themes - apply those themes to your code and then resubmit for review. | |
| Nov 26, 2019 at 19:29 | comment | added | bentleytrader | @IEatBagels Yes, the code is taking Names, IDs, and Departments and comparing it against a directory of all active employees. The code will then output Name, ID,Department, and add whether the employee is found in one list or the other. If the employee is in both lists then there is no message in the output | |
| Nov 26, 2019 at 19:23 | comment | added | IEatBagels | Could you add detail to explain what your code does? | |
| Nov 26, 2019 at 18:25 | history | edited | πάντα ῥεῖ |
edited tags
|
|
| Nov 26, 2019 at 18:25 | review | First posts | |||
| Nov 26, 2019 at 19:23 | |||||
| Nov 26, 2019 at 18:24 | history | asked | bentleytrader | CC BY-SA 4.0 |