Skip to main content
small clarification
Source Link
S.S. Anne
  • 1.7k
  • 8
  • 27

If a GCC-compatible compiler (gcc, clang, icc, etc.) is detected during the build process, the flags -std=gnu99 -O2 are appended to the build flags.

If a GCC-compatible compiler (gcc, clang, icc, etc.) is detected during the build process, the flags -std=gnu99 -O2 are appended to the build flags.

a little clarification
Source Link
S.S. Anne
  • 1.7k
  • 8
  • 27
  • Portability. Is this portable? Will it work on all common platforms (x86, arm, etc.) and possibly some uncommon ones?

  • Comments. The comments I've put here seem to already document the code well enough, but is there any additional information I could add?

  • Hidden Bugs. This definitely works (and has a noticeable improvement in speed), but are there any hidden bugs relating to alignment requirements or otherwise (such as extended ASCII)? For context, this is part of a standard C/POSIX library implementation.

  • Portability. Is this portable? Will it work on all common platforms (x86, arm, etc.) and possibly some uncommon ones?

  • Comments. The comments I've put here seem to already document the code well enough, but is there any additional information I could add?

  • Hidden Bugs. This definitely works (and has a noticeable improvement in speed), but are there any hidden bugs relating to alignment requirements or otherwise (such as extended ASCII)? For context, this is part of a standard C library implementation.

  • Portability. Is this portable? Will it work on all common platforms (x86, arm, etc.) and possibly some uncommon ones?

  • Comments. The comments I've put here seem to already document the code well enough, but is there any additional information I could add?

  • Hidden Bugs. This definitely works (and has a noticeable improvement in speed), but are there any hidden bugs relating to alignment requirements or otherwise (such as extended ASCII)? For context, this is part of a standard C/POSIX library implementation.

Tweeted twitter.com/StackCodeReview/status/1191596132301979648
added 126 characters in body
Source Link
S.S. Anne
  • 1.7k
  • 8
  • 27

I might note that I'm relying on my header to use the builtin version of ffs. This may be an issue on non-GNU compilers.

I might note that I'm relying on my header to use the builtin version of ffs. This may be an issue on non-GNU compilers.

Source Link
S.S. Anne
  • 1.7k
  • 8
  • 27
Loading